[Rprotobuf-yada] bytes

[Dirk Eddelbuettel]

Koert,

Yikes!! -- I just noticed this sitting unattended in a procmail-sorted mail
folder for four days. Ouch. Sorry about that.

On 8 October 2010 at 10:21, eckuipers-web at yahoo.com wrote:
| Hey Dirk and Romain,
| Attached is my patch to rprotobuf revision 392 so that protobuf bytes objects 
| are represented by R raws (or lists of raws if it is a repeated field).
| Note that if you assign a raw vector to a repeated bytes field it only adds a 
| single element. To add multiple elements you have to assign a list of raws.
| I did some ad hoc testing so far but nothing rigorous yet. Also not sure how 
| this impacts the unitTests...

Can you run 'R CMD check RProtoBuf' ?  That would run them too...

And I guess we would need to design a unit test or two or three to test the
new functionality, no?   

Thanks for the submission. It looks good so far.

Cheers, Dirk

| Best,
| Koert
| 
| 
| 
| 
| 
| 
| 
| ----- Original Message ----
| From: Dirk Eddelbuettel <edd at debian.org>
| To: eckuipers-web at yahoo.com
| Cc: Dirk Eddelbuettel <edd at debian.org>; 
| rprotobuf-yada at lists.r-forge.r-project.org
| Sent: Sat, September 11, 2010 1:17:02 PM
| Subject: Re: [Rprotobuf-yada] bytes
| 
| 
| On 11 September 2010 at 10:00, eckuipers-web at yahoo.com wrote:
| | OK I will give the patch a try. 
| 
| Great!
| 
| | I am unfamiliar with Rcpp so not sure how of much help i can be...
| 
| We do help on the rcpp-dev list which has more readers.  And Rcpp is more
| versatile so you had to learn that anyway ;-)
| 
| Dirk
| 
| -- 
| Dirk Eddelbuettel | edd at debian.org | http://dirk.eddelbuettel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_rprotobuf_r392.diff.tar.gz
Type: application/x-gzip
Size: 3170 bytes
Desc: not available
URL: <http://lists.r-forge.r-project.org/pipermail/rprotobuf-yada/attachments/20101012/703a9b64/attachment.bin>
-------------- next part --------------

-- 
Dirk Eddelbuettel | edd at debian.org | http://dirk.eddelbuettel.com