[Rprotobuf-yada] bytes

[eckuipers-web at yahoo.com]

One test bombs but that has nothing to do with my changes i think. RUnit can't 
parse the R file runit.addressbook.R which is odd since it seems perfectly fine 
to me.
I can add some unittests later in the week with respect to raws and my 
changes...
Koert


koert at ubuntu-koert:~/src/rprotobuf$ Rscript pkg/tests/doRUnit.R 
Loading required package: methods
Loading required package: RProtoBuf
Loading required package: RCurl
Loading required package: bitops
Loading required package: Rcpp

> pkg <- "RProtoBuf"

> if (require("RUnit", quietly = TRUE)) {
+     library(package = pkg, character.only = TRUE)
+     if (!(exists("path") && file.exists(path))) 
+     .... [TRUNCATED] 
Error in parse(n = -1, file = file) : 30:0: unexpected end of input
28:     checkEquals(book$person[[2]]$phone[[1]]$type,   0,                   
msg="Second person phone number")
29: }
   ^


Executing test function test.import  ...  done successfully.



Executing test function test.readProtoFile  ...  done successfully.




----- Original Message ----
From: Dirk Eddelbuettel <edd at debian.org>
To: eckuipers-web at yahoo.com
Cc: Dirk Eddelbuettel <edd at debian.org>; 
rprotobuf-yada at lists.r-forge.r-project.org
Sent: Tue, October 12, 2010 4:43:34 PM
Subject: Re: [Rprotobuf-yada] bytes


Koert,

Yikes!! -- I just noticed this sitting unattended in a procmail-sorted mail
folder for four days. Ouch. Sorry about that.

On 8 October 2010 at 10:21, eckuipers-web at yahoo.com wrote:
| Hey Dirk and Romain,
| Attached is my patch to rprotobuf revision 392 so that protobuf bytes objects 
| are represented by R raws (or lists of raws if it is a repeated field).
| Note that if you assign a raw vector to a repeated bytes field it only adds a 
| single element. To add multiple elements you have to assign a list of raws.
| I did some ad hoc testing so far but nothing rigorous yet. Also not sure how 
| this impacts the unitTests...

Can you run 'R CMD check RProtoBuf' ?  That would run them too...

And I guess we would need to design a unit test or two or three to test the
new functionality, no?  

Thanks for the submission. It looks good so far.

Cheers, Dirk

| Best,
| Koert
| 
| 
| 
| 
| 
| 
| 
| ----- Original Message ----
| From: Dirk Eddelbuettel <edd at debian.org>
| To: eckuipers-web at yahoo.com
| Cc: Dirk Eddelbuettel <edd at debian.org>; 
| rprotobuf-yada at lists.r-forge.r-project.org
| Sent: Sat, September 11, 2010 1:17:02 PM
| Subject: Re: [Rprotobuf-yada] bytes
| 
| 
| On 11 September 2010 at 10:00, eckuipers-web at yahoo.com wrote:
| | OK I will give the patch a try. 
| 
| Great!
| 
| | I am unfamiliar with Rcpp so not sure how of much help i can be...
| 
| We do help on the rcpp-dev list which has more readers.  And Rcpp is more
| versatile so you had to learn that anyway ;-)
| 
| Dirk
| 
| -- 
| Dirk Eddelbuettel | edd at debian.org | http://dirk.eddelbuettel.com

-- 
Dirk Eddelbuettel | edd at debian.org | http://dirk.eddelbuettel.com