[Phylobase-devl] phylobase status

[François Michonneau]

Hi Ben,

  I'm currently in the field and won't have a chance to look into it until
early December. As I recall most (if not all) of these stdout/stderr are
actually remnants of the initial hack of NCL. The phylobase interface was
developed based on some example code provided with NCL that was a basic
command line parser of NEXUS files. From what I remember, most of these
stdout/stderr lines are not used by phylobase at all and could possibly be
removed without affecting the rest of the code.

  Cheers,
  -- François

On Mon, Nov 12, 2012 at 10:40 AM, Jombart, Thibaut <t.jombart at imperial.ac.uk
> wrote:

> Hi Ben,
>
> thanks for looking into this. About the printf/Rprintf thing, I've had to
> make the changes on other packages recently. If it's remained unnoticed
> thus far I'm afraid there's a good chance the CRAN maintainer will pick up
> on this soon. Sorry, I don't do C++ so can't make the changes.
>
> Cheers
>
> Thibaut
>
>
> ________________________________________
> From: phylobase-devl-bounces at lists.r-forge.r-project.org [
> phylobase-devl-bounces at lists.r-forge.r-project.org] on behalf of Ben
> Bolker [bbolker at gmail.com]
> Sent: 12 November 2012 14:42
> To: phylobase-devl at lists.r-forge.r-project.org; Emmanuel Paradis
> Subject: [Phylobase-devl] phylobase status
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
>
>   I spent a little while cleaning up some problems with phylobase (the
> version on CRAN looks broken -- I don't know how long it's been that
> way).  It now passes checks on my machine with a couple of NOTEs, one
> about the size of the 'libs' directory (which we can't really do
> anything about), and one about redirection of output to stdout and
> stderr, which is frowned upon.
>
> There appear to be 34 instances of this in the C++ code:
>
> grep  "\(cout\|cerr\)" *.cpp | wc
>      34     563    3761
>
>   Is someone willing to spend an hour or so figuring out how to
> replace these appropriately?  (section 6.5 of the R-exts manual says
> to use Rprintf and REprintf)  This has gone under the radar so far,
> but I can imagine CRAN (who have been getting stricter and stricter)
> will complain about this when we resubmit.
>
>   This is with ape 3.0-6; as I said, it otherwise tests clean on my
> machine, we'll see whether R-Forge complains or not.
>
>   Volunteers?
>
>    cheers
>      Ben
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
>
> iQEcBAEBAgAGBQJQoQq6AAoJEOCV5YRblxUHSkYH+waRunjoPcMdWfjhM4nVfdUd
> LA/tX+RcQ84rjmt5IEkzY7oYsWdHi2JDFFcOcat51XL4RywfyUpb97t9uc+CPaQM
> dcgH+3Pxr0cmziZtdU9uKeQfwwnsk1zkfTmd034bd2QiOBivSbNs+maqZjohJRSy
> PM/iDQYRNCZ0gAliXsUbRtbOuj+gKay6mbo5coFQ+oB5dv5xXSzJV8wXaQ9WsEme
> MjZSbNEtQUuWF6tJ3WDQCDDaGJWb6x23UJt6W0soM2UxUDqwvZAcyM19MbgdXKm5
> xRkMF7+u86dLkUfN7AUMiBSPHbKcvA/FwFUXit6g1svrAw00akRIII/T3IiPjR8=
> =fkko
> -----END PGP SIGNATURE-----
> _______________________________________________
> Phylobase-devl mailing list
> Phylobase-devl at lists.r-forge.r-project.org
> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/phylobase-devl
> _______________________________________________
> Phylobase-devl mailing list
> Phylobase-devl at lists.r-forge.r-project.org
> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/phylobase-devl
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.r-forge.r-project.org/pipermail/phylobase-devl/attachments/20121112/7bc67c76/attachment.html>