[GenABEL-dev] [Genabel-commits] r1705 - pkg/ProbABEL/src

[Maarten Kooyman]

Dear all,

I think it is easier to use for code review github:

Please check to get a impression 
:https://github.com/jquery/jquery/pull/1241/files

I think we should reconsider an other the software version system: the 
current system is not up to date to current usability. Bug tracking and 
branching is quite hard in terms of usability. Please have a look at 
github.com to get a impression what is possible.

Kind regards,

Maarten



On 28-04-14 16:55, L.C. Karssen wrote:
> Dear non-Dutch speaking list members,
>
> Here's a short translation of the previous e-mail for those who don't
> speak Dutch :-).
>
>
> Dear Maarten (and others of course),
>
> As you must have noticed, I started to review commits. Please feel free
> to review my commits as well. I will learn from those reviews as well
> and hopefully these reviews indicate that this is normal procedure (from
> which I don't want to be exempt).
>
>
> Best,
>
> Lennart.
>
> On 28-04-14 16:46, L.C. Karssen wrote:
>> Hoi Maarten,
>>
>> Zoals je wel hebt gemerkt ben ik geabonneerd op de commit list en
>> probeer ik alle commits te reviewen en waar nodig van kritisch
>> commentaar te voorzien.
>> Als je tijd hebt staat het je natuurlijk volledig vrij om dat ook bij
>> mijn commits te doen. Daar leer ik ook weer van en het geeft hopelijk
>> aan dat er dit soort reviews de normale gang van zaken zijn.
>>
>>
>>
>> Groeten,
>>
>> Lennart.
>>
>> On 28-04-14 13:57, Maarten Kooyman wrote:
>>> On 28-04-14 12:03, L.C. Karssen wrote:
>>>> Hi Maarten,
>>>>
>>>> That's interesting. I assume you did this in response to bug #5658?
>>> Yes.
>>>> The change you made is only for ASCII input files, right?
>>> Yes.
>>>
>>>> Any idea how
>>>> this is treated in GenABEL's mach2databel() and impute2databel()?
>>> I do not have an idea. Maybe check out the speed of reading those format
>>> and convert the strategy used in the trunk of ProABEL.(Those are
>>> generally only done once per dataset so it is not high on the priority
>>> list.)
>>>>    I
>>>> assume the NAs are converted to IEEE754 compatible NaN there, but I'm
>>>> not sure. If that is the case, then this would fix that bug, right?
>>> Assumption is the mother of all... But if your sure, it is fixed.
>>>>
>>>> Lennart.
>>> Kind regards,
>>>
>>> Maarten
>>> _______________________________________________
>>> Genabel-commits mailing list
>>> Genabel-commits at lists.r-forge.r-project.org
>>> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-commits
>>>
>>
>>
>> _______________________________________________
>> genabel-devel mailing list
>> genabel-devel at lists.r-forge.r-project.org
>> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel
>>
>
>
> _______________________________________________
> genabel-devel mailing list
> genabel-devel at lists.r-forge.r-project.org
> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.r-forge.r-project.org/pipermail/genabel-devel/attachments/20140428/802777a7/attachment.html>