[GenABEL-dev] [Genabel-commits] r1705 - pkg/ProbABEL/src

[L.C. Karssen]

Dear non-Dutch speaking list members,

Here's a short translation of the previous e-mail for those who don't
speak Dutch :-).


Dear Maarten (and others of course),

As you must have noticed, I started to review commits. Please feel free
to review my commits as well. I will learn from those reviews as well
and hopefully these reviews indicate that this is normal procedure (from
which I don't want to be exempt).


Best,

Lennart.

On 28-04-14 16:46, L.C. Karssen wrote:
> Hoi Maarten,
> 
> Zoals je wel hebt gemerkt ben ik geabonneerd op de commit list en
> probeer ik alle commits te reviewen en waar nodig van kritisch
> commentaar te voorzien.
> Als je tijd hebt staat het je natuurlijk volledig vrij om dat ook bij
> mijn commits te doen. Daar leer ik ook weer van en het geeft hopelijk
> aan dat er dit soort reviews de normale gang van zaken zijn.
> 
> 
> 
> Groeten,
> 
> Lennart.
> 
> On 28-04-14 13:57, Maarten Kooyman wrote:
>> On 28-04-14 12:03, L.C. Karssen wrote:
>>> Hi Maarten,
>>>
>>> That's interesting. I assume you did this in response to bug #5658?
>> Yes.
>>> The change you made is only for ASCII input files, right?
>> Yes.
>>
>>> Any idea how
>>> this is treated in GenABEL's mach2databel() and impute2databel()?
>> I do not have an idea. Maybe check out the speed of reading those format
>> and convert the strategy used in the trunk of ProABEL.(Those are
>> generally only done once per dataset so it is not high on the priority
>> list.)
>>>   I
>>> assume the NAs are converted to IEEE754 compatible NaN there, but I'm
>>> not sure. If that is the case, then this would fix that bug, right?
>> Assumption is the mother of all... But if your sure, it is fixed.
>>>
>>>
>>> Lennart.
>>
>> Kind regards,
>>
>> Maarten
>> _______________________________________________
>> Genabel-commits mailing list
>> Genabel-commits at lists.r-forge.r-project.org
>> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-commits
>>
> 
> 
> 
> _______________________________________________
> genabel-devel mailing list
> genabel-devel at lists.r-forge.r-project.org
> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel
> 

-- 
*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*
L.C. Karssen
Utrecht
The Netherlands

lennart at karssen.org
http://blog.karssen.org
GPG key ID: A88F554A
-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: OpenPGP digital signature
URL: <http://lists.r-forge.r-project.org/pipermail/genabel-devel/attachments/20140428/12c45e96/attachment.sig>