<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Dear all,<br>
<br>
I think it is easier to use for code review github:<br>
<br>
Please check to get a impression
:<a class="moz-txt-link-freetext" href="https://github.com/jquery/jquery/pull/1241/files">https://github.com/jquery/jquery/pull/1241/files</a><br>
<br>
I think we should reconsider an other the software version system:
the current system is not up to date to current usability. Bug
tracking and branching is quite hard in terms of usability. Please
have a look at github.com to get a impression what is possible.<br>
<br>
Kind regards,<br>
<br>
Maarten<br>
<br>
<br>
<br>
On 28-04-14 16:55, L.C. Karssen wrote:<br>
</div>
<blockquote cite="mid:535E6BDB.3000206@karssen.org" type="cite">
<pre wrap="">Dear non-Dutch speaking list members,
Here's a short translation of the previous e-mail for those who don't
speak Dutch :-).
Dear Maarten (and others of course),
As you must have noticed, I started to review commits. Please feel free
to review my commits as well. I will learn from those reviews as well
and hopefully these reviews indicate that this is normal procedure (from
which I don't want to be exempt).
Best,
Lennart.
On 28-04-14 16:46, L.C. Karssen wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hoi Maarten,
Zoals je wel hebt gemerkt ben ik geabonneerd op de commit list en
probeer ik alle commits te reviewen en waar nodig van kritisch
commentaar te voorzien.
Als je tijd hebt staat het je natuurlijk volledig vrij om dat ook bij
mijn commits te doen. Daar leer ik ook weer van en het geeft hopelijk
aan dat er dit soort reviews de normale gang van zaken zijn.
Groeten,
Lennart.
On 28-04-14 13:57, Maarten Kooyman wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 28-04-14 12:03, L.C. Karssen wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi Maarten,
That's interesting. I assume you did this in response to bug #5658?
</pre>
</blockquote>
<pre wrap="">Yes.
</pre>
<blockquote type="cite">
<pre wrap="">The change you made is only for ASCII input files, right?
</pre>
</blockquote>
<pre wrap="">Yes.
</pre>
<blockquote type="cite">
<pre wrap="">Any idea how
this is treated in GenABEL's mach2databel() and impute2databel()?
</pre>
</blockquote>
<pre wrap="">I do not have an idea. Maybe check out the speed of reading those format
and convert the strategy used in the trunk of ProABEL.(Those are
generally only done once per dataset so it is not high on the priority
list.)
</pre>
<blockquote type="cite">
<pre wrap=""> I
assume the NAs are converted to IEEE754 compatible NaN there, but I'm
not sure. If that is the case, then this would fix that bug, right?
</pre>
</blockquote>
<pre wrap="">Assumption is the mother of all... But if your sure, it is fixed.
</pre>
<blockquote type="cite">
<pre wrap="">
Lennart.
</pre>
</blockquote>
<pre wrap="">
Kind regards,
Maarten
_______________________________________________
Genabel-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Genabel-commits@lists.r-forge.r-project.org">Genabel-commits@lists.r-forge.r-project.org</a>
<a class="moz-txt-link-freetext" href="https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-commits">https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-commits</a>
</pre>
</blockquote>
<pre wrap="">
_______________________________________________
genabel-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:genabel-devel@lists.r-forge.r-project.org">genabel-devel@lists.r-forge.r-project.org</a>
<a class="moz-txt-link-freetext" href="https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel">https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel</a>
</pre>
</blockquote>
<pre wrap="">
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
genabel-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:genabel-devel@lists.r-forge.r-project.org">genabel-devel@lists.r-forge.r-project.org</a>
<a class="moz-txt-link-freetext" href="https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel">https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel</a></pre>
</blockquote>
<br>
</body>
</html>