[Rcpp-devel] Patch for using Rcpp with proper check of TR1/C++11 headers

[Romain Francois]

Le 03/12/12 13:41, Dirk Eddelbuettel a écrit :
>
> Yan,
>
> On 3 December 2012 at 06:11, Yan Zhou wrote:
> | Here is a more detailed summary of the change and some test results
>
> Wow. What a detailed email -- much appreciated.  I will try to fold this in
> this evening.  As you may have noticed, things do change in SVN so we have to
> catch it there.
>
> Your patch looks good and careful, nice work. At a first glance, tThe only
> thing I am a little hesitant about the comparator const change. Romain has/is
> doing a lot of work on const correctness (and we need a lot more work).  But
> maybe this was something we simply forgot...

It is alright. I forgot to put it on.

> I hope to be able to fold this in this evening, unless some other troubles
> surfaces.  I really appreciate your testing.  If there is a way for us to
> leverage your test farm it would a big win.
>
> Cheers,  Dirk
>
>
> | Index: pkg/Rcpp/inst/include/Rcpp/traits/comparator_type.h
> | ===================================================================
> | --- pkg/Rcpp/inst/include/Rcpp/traits/comparator_type.h	(revision 4055)
> | +++ pkg/Rcpp/inst/include/Rcpp/traits/comparator_type.h	(working copy)
> | @@ -28,7 +28,7 @@
> |
> |  class StringCompare {
> |  public:
> | -    inline bool operator()( SEXP x, SEXP y){
> | +    inline bool operator()( SEXP x, SEXP y) const {
> |          return strcmp( char_nocheck(x), char_nocheck(y) ) < 0 ;
> |      }
> |  } ;
>
>


-- 
Romain Francois
Professional R Enthusiast
+33(0) 6 28 91 30 30

R Graph Gallery: http://gallery.r-enthusiasts.com
`- http://bit.ly/SweN1Z : SuperStorm Sandy

blog:            http://romainfrancois.blog.free.fr
|- http://bit.ly/RE6sYH : OOP with Rcpp modules
`- http://bit.ly/Thw7IK : Rcpp modules more flexible