[Phylobase-devl] path between two tips
Thibaut Jombart
jombart at biomserv.univ-lyon1.fr
Fri Nov 21 10:55:59 CET 2008
Hilmar Lapp wrote:
> Isn't it easy enough for the caller to prepend (or append, depending
> on the order in which ancestors() returns nodes, assuming that it does
> return them ordered) the node to the array?
>
> I.e., does having to do
>
> ALLancestors <- c(t1, ancestors(x, t1, which="all"))
>
> really warrant an extra option to ancestors()?
>
> I'm probably missing something obvious here, so feel free to set me
> straight if I'm off track.
>
> -hilmar
>
I would agree with Hilmar. Plus, the arguments of 'ancestors' become:
> args(ancestors)
function (phy, node, which = c("all", "parent", "ALL"))
which is misleading. I think we could just keep the previous version of
ancestors and use smthg like
c(t1, ancestors(x, t1, which="all"))
inside MRCA.
Cheers,
Thibaut.
More information about the Phylobase-devl
mailing list