[Lme4-commits] r1731 - pkg/lme4/R

[noreply at r-forge.r-project.org]

Author: bbolker
Date: 2012-05-15 20:02:58 +0200 (Tue, 15 May 2012)
New Revision: 1731

Modified:
   pkg/lme4/R/lmer.R
Log:

  add warning for lmer+family -> glmer case



Modified: pkg/lme4/R/lmer.R
===================================================================
--- pkg/lme4/R/lmer.R	2012-05-15 18:02:30 UTC (rev 1730)
+++ pkg/lme4/R/lmer.R	2012-05-15 18:02:58 UTC (rev 1731)
@@ -86,6 +86,7 @@
     ## '...' handling up front, safe-guarding against typos ("familiy") :
     if(length(l... <- list(...))) {
         if (!is.null(l...$family)) {  # call glmer if family specified
+            warning("calling lmer with family() is deprecated: please use glmer() instead")
             mc[[1]] <- as.name("glmer")
             return(eval(mc, parent.frame()) )
         }
@@ -835,6 +836,7 @@
         P[nas] <- stats:::safe_pchisq(dev[nas], dfs[nas], lower.tail = FALSE)
         aod[, c("LRT", "Pr(Chi)")] <- list(dev, P)
     } else if (test == "F") {
+        ## FIXME: allow this if denominator df are specified externally?
         stop("F test STUB -- unfinished maybe forever")
         dev <- ans[, 2L] - k*ans[, 1L]
         dev <- dev - dev[1L] ; dev[1L] <- NA
@@ -1795,7 +1797,7 @@
     REML <- isREML(object)
 
     link <- fam <- NULL
-    if(is(resp, "glmerResp")) {
+    if(is(resp, "glmerResp")) {  ## FIXME: ?? should be "glmResp", or?? isGLMM(object) ??
         fam <- resp$family$family
         link <- resp$family$link
     }