[GenABEL-dev] [Genabel-commits] r1596 - branches/ProbABEL-0.50

[Maarten Kooyman]

Hi Lennart,

It does not look that -Wextra produce any extra warnings.

On 05-02-14 22:16, L.C. Karssen wrote:
> Hi Maarten,
>
> I haven't yet compiled this branch, but will be interested to see what
> -Wextra gives in terms of warnings.
>
> One more question below:
>
> On 05-02-14 21:26, noreply at r-forge.r-project.org wrote:
>> Author: maartenk
>> Date: 2014-02-05 21:26:01 +0100 (Wed, 05 Feb 2014)
>> New Revision: 1596
>>
>> Modified:
>>     branches/ProbABEL-0.50/configure.ac
>> Log:
>> added  CXXflags -DEIGENNO_DEBUG :removes checks for conformability (which gives a speedup in eigen)
>> added  CXXflags -Wextra: adds adittional check (see http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html for more info)
>>
>>
>>
>>
>>
>> Modified: branches/ProbABEL-0.50/configure.ac
>> ===================================================================
>> --- branches/ProbABEL-0.50/configure.ac	2014-02-05 16:35:59 UTC (rev 1595)
>> +++ branches/ProbABEL-0.50/configure.ac	2014-02-05 20:26:01 UTC (rev 1596)
>> @@ -21,9 +21,10 @@
>>   AC_PROG_LN_S
>>   if test -z "$CXXFLAGS"; then
>>      # User did not set CXXFLAGS, so we can put in our own defaults
>> -    CXXFLAGS="-g -O2"
>> +    CXXFLAGS="-g -O2 -DEIGEN_NO_DEBUG -Wextra"
>>   fi
>> -if test -z "$CPPFLAGS"; then
>> +if test -z "$
>> +"; then
>>      # User did not set CPPFLAGS, so we can put in our own defaults
>>       CPPFLAGS="-Wall"
>>   fi
>>
> Is this correct? It seems that the name of the CPPFLAGS variable was
> removed and
> ";then
> moved to a new line.

Well spotted! This was a copy paste error. I committed a fix.

  I think there should be a configure option to use or use not -DNDEBUG: 
disabling this is inconvenient when developing and debugging. I think 
something like ./configure --develop-flags. I don't have  any experience 
with autotools, so this might take a while.
>
>
>
> Thanks,
>
> Lennart.
>
>> _______________________________________________
>> Genabel-commits mailing list
>> Genabel-commits at lists.r-forge.r-project.org
>> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-commits
>>
>
>
> _______________________________________________
> genabel-devel mailing list
> genabel-devel at lists.r-forge.r-project.org
> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.r-forge.r-project.org/pipermail/genabel-devel/attachments/20140206/dff2f5f6/attachment.html>