<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi Lennart,<br>
<br>
It does not look that -Wextra
produce any extra warnings.<br>
<br>
On 05-02-14 22:16, L.C. Karssen wrote:<br>
</div>
<blockquote cite="mid:52F2AA3E.6080200@karssen.org" type="cite">
<pre wrap="">Hi Maarten,
I haven't yet compiled this branch, but will be interested to see what
-Wextra gives in terms of warnings.
One more question below:
On 05-02-14 21:26, <a class="moz-txt-link-abbreviated" href="mailto:noreply@r-forge.r-project.org">noreply@r-forge.r-project.org</a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Author: maartenk
Date: 2014-02-05 21:26:01 +0100 (Wed, 05 Feb 2014)
New Revision: 1596
Modified:
branches/ProbABEL-0.50/configure.ac
Log:
added CXXflags -DEIGENNO_DEBUG :removes checks for conformability (which gives a speedup in eigen)
added CXXflags -Wextra: adds adittional check (see <a class="moz-txt-link-freetext" href="http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html">http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html</a> for more info)
Modified: branches/ProbABEL-0.50/configure.ac
===================================================================
--- branches/ProbABEL-0.50/configure.ac 2014-02-05 16:35:59 UTC (rev 1595)
+++ branches/ProbABEL-0.50/configure.ac 2014-02-05 20:26:01 UTC (rev 1596)
@@ -21,9 +21,10 @@
AC_PROG_LN_S
if test -z "$CXXFLAGS"; then
# User did not set CXXFLAGS, so we can put in our own defaults
- CXXFLAGS="-g -O2"
+ CXXFLAGS="-g -O2 -DEIGEN_NO_DEBUG -Wextra"
fi
-if test -z "$CPPFLAGS"; then
+if test -z "$
+"; then
# User did not set CPPFLAGS, so we can put in our own defaults
CPPFLAGS="-Wall"
fi
</pre>
</blockquote>
<pre wrap="">
Is this correct? It seems that the name of the CPPFLAGS variable was
removed and
";then
moved to a new line.</pre>
</blockquote>
<br>
Well spotted! This was a copy paste error. I committed a fix.<br>
<br>
I think there should be a configure option to use or use not
-DNDEBUG: disabling this is inconvenient when developing and
debugging. I think something like ./configure --develop-flags. I
don't have any experience with autotools, so this might take a
while. <br>
<blockquote cite="mid:52F2AA3E.6080200@karssen.org" type="cite">
<pre wrap="">
Thanks,
Lennart.
</pre>
<blockquote type="cite">
<pre wrap="">_______________________________________________
Genabel-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Genabel-commits@lists.r-forge.r-project.org">Genabel-commits@lists.r-forge.r-project.org</a>
<a class="moz-txt-link-freetext" href="https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-commits">https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-commits</a>
</pre>
</blockquote>
<pre wrap="">
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
genabel-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:genabel-devel@lists.r-forge.r-project.org">genabel-devel@lists.r-forge.r-project.org</a>
<a class="moz-txt-link-freetext" href="https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel">https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel</a></pre>
</blockquote>
<br>
</body>
</html>