[GenABEL-dev] Fwd: C++ which is not valid C++11 in CRAN package DatABEL

[Yurii Aulchenko]

Re: splitting. No idea. They (CRAN) asked it. Can imagine this is related
to CRAN infrastructure (remember they have 1000s of packages).

Y


On Wed, Nov 6, 2013 at 11:27 PM, L.C. Karssen <lennart at karssen.org> wrote:

> In the mean time I did a second commit, which fixed the same isnan()
> error in ITERlib.
> Now GenABEL compiles without warnings on my system (unless you add -Wall
> -pedantic to the CFLAGS, but those shouldn't be show stoppers).
>
>
> Hmm... Splitting the data in a separate package. What was the reasoning
> behind that? OK, it would make for a lighter main package, but for the
> examples to work, we still need them. And the GenABEL tar.gz is only
> ~5MB (the actual data directory is ~2.4MB), that should be ok for modern
> standards, right? The Writing R Extensions manual talks about very large
> datasets, but mentions 2GB in that respect.
> We already download the files needed for creating the tutorial
> separately...
>
>
> Lennart.
>
> On 06-11-13 18:46, Yurii Aulchenko wrote:
> > Thank you very much! - time for genabel resubmission... Dread it a bit
> > as other request was to put all the data in separate package...
> >
> > ----------------------
> > Yurii Aulchenko
> > (sent from mobile device)
> >
> >> On Nov 6, 2013, at 14:22, "L.C. Karssen" <lennart at karssen.org> wrote:
> >>
> >> I added  -Wall -std=c++11 to the Makefile in pkg/filevector/. This
> >> resulted in an error  (about an ambiguous isnan() function definition)
> >> The fix in SVN r.1361 fixes that error.
> >>
> >> Hopefully that's enough. If not, let me know.
> >>
> >>
> >> Lennart.
> >>
> >>> On 11/06/2013 11:37 AM, Yurii Aulchenko wrote:
> >>> FYI
> >>>
> >>> I expect this is the same code (filevector?) as that in previous FYI
> >>> causing complains
> >>>
> >>> ---------- Forwarded message ----------
> >>> From: *Prof Brian Ripley* <ripley at stats.ox.ac.uk
> >>> <mailto:ripley at stats.ox.ac.uk>>
> >>> Date: Wed, Nov 6, 2013 at 10:20 AM
> >>> Subject: C++ which is not valid C++11 in CRAN package DatABEL
> >>> To: yurii at bionet.nsc.ru <mailto:yurii at bionet.nsc.ru>
> >>>
> >>>
> >>> We now have compilers (gcc 4.8.2, clang with libcxx headers) with
> >>> fairly complete C++11 support (which can be selected by -std=c++11).
> >>> At least one of these is showing compilation errors on your package,
> >>> which were in many cases warnings under earlier versions of g++
> >>> (provided -Wall was used: see 'Writing R Extensions').  People are
> >>> pressing that this become the default where supported.
> >>>
> >>> You can see the compilation logs at e.g.
> >>>
> http://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-clang/BiasedUrn-00check.html
> >>> and
> >>> http://www.stats.ox.ac.uk/pub/bdr/memtests/ASAN/BiasedUrn.log .
> >>>
> >>>
> >>> Please submit an update to CRAN (following the CRAN policies) at
> >>> http://cran.r-project.org/web/packages/policies.html.  Do NOT reply to
> >>> this email to submit an update!
> >>>
> >>> There may be other issues that need fixing: see the CRAN check logs at
> >>> http://cran.r-project.org/web/checks/check_results_NAME.html,
> >>> replacing NAME by the name of your package.
> >>>
> >>>
> >>>
> >>> --
> >>> -----------------------------------------------------
> >>> Yurii S. Aulchenko
> >>>
> >>> [ LinkedIn <http://nl.linkedin.com/in/yuriiaulchenko> ] [ Twitter
> >>> <http://twitter.com/YuriiAulchenko> ] [ Blog
> >>> <http://yurii-aulchenko.blogspot.nl/> ]
> >>>
> >>>
> >>> _______________________________________________
> >>> genabel-devel mailing list
> >>> genabel-devel at lists.r-forge.r-project.org
> >>>
> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel
> >>
> >> --
> >> *-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*
> >> L.C. Karssen
> >> Utrecht
> >> The Netherlands
> >>
> >> lennart at karssen.org
> >> http://blog.karssen.org
> >> GPG key ID: A88F554A
> >> -*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-
> >>
> >> _______________________________________________
> >> genabel-devel mailing list
> >> genabel-devel at lists.r-forge.r-project.org
> >>
> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel
>
> --
> -----------------------------------------------------------------
> L.C. Karssen
> Utrecht
> The Netherlands
>
> lennart at karssen.org
> http://blog.karssen.org
>
> Stuur mij aub geen Word of Powerpoint bestanden!
> Zie http://www.gnu.org/philosophy/no-word-attachments.nl.html
> ------------------------------------------------------------------
>
>


-- 
-----------------------------------------------------
Yurii S. Aulchenko

[ LinkedIn <http://nl.linkedin.com/in/yuriiaulchenko> ] [
Twitter<http://twitter.com/YuriiAulchenko>] [
Blog <http://yurii-aulchenko.blogspot.nl/> ]
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.r-forge.r-project.org/pipermail/genabel-devel/attachments/20131107/d3a32e81/attachment.html>