[GenABEL-dev] bug_in_OmicABEL_reshuffle_fixed

[Yurii Aulchenko]

Thanks, Sodbo - does pass my test now! :)

This is actually very good - I was so depressed not seeing any association,
then happy to discover a bug, and now even more happy to see quite a few
significant hits!

YA

On Mon, Jul 1, 2013 at 9:51 AM, Содбо Шарапов <sharapovsodbo at gmail.com>wrote:

> Dear all!
> I fixed bug in OmicABEL_reshuffle.
> This bug was only for big data. The reason is, that for big output data
> value of tile_coordinate is higher, than max(int).
> For example: for data with 1080 ids and 122756 SNPs
> max(tile_coordinate)=1080(ids) * 122756(SNPs) * 8 (sizeof(double)) * 5
> (columns:beta_1,se_1,beta_SNP,se_SNP, etc) =  5 303 059 200
> max(int) = 2 147 483 647
> max(unsigned int) = 4 294 967 295
> This values is lower than max(tile_coordinate). That's why
> tile_coordinates for a half of data were incorrect and senseless.
> So, the solution of this problem is change type of variabels for
> tile_coordinates: I select int64_t instead of int.
> max (int64_t)= 9,223,372,036,854,775,808. I think this is enough!=)
> Now, "reshuffle" works with big data correctly. Compilation for Linux and
> Windows was succesful.
> --
> *_________________________________*
> *
> *With best regards
>
> Sodbo Zh. Sharapov
> Phone:  +79831347688
> Email:    sharapovsodbo at gmail.com
>              sharapov at bionet.nsc.ru
> Skype:   sharapovsodbo
>
> _______________________________________________
> genabel-devel mailing list
> genabel-devel at lists.r-forge.r-project.org
> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel
>



-- 
-----------------------------------------------------
Yurii S. Aulchenko

[ LinkedIn <http://nl.linkedin.com/in/yuriiaulchenko> ] [
Twitter<http://twitter.com/YuriiAulchenko>] [
Blog <http://yurii-aulchenko.blogspot.nl/> ]
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.r-forge.r-project.org/pipermail/genabel-devel/attachments/20130701/1424be47/attachment.html>