[Roxygen-devel] [roxygen2] roxygenise, setGeneric and .svn directory

Hadley Wickham hadley at rice.edu
Tue Aug 16 15:16:43 CEST 2011


> judging by the time stamps, which won't be updated after a first round,
> roxygenize() seems to try to write those files at least a second time after
> they have already been copied (i mean within one call). which perhaps fails
> because of some "overwrite=FALSE" or so. but apart from that, it would be a
> clean solution to skip all version control system directorys like .svn, .cvs
> ... completely. they can be copied to "roxygen.dir", but roxygenize() actually
> has no business to even read them afterwards, there's nothing to be done in
> those dirs. if it would do any changes below .svn/, it could even mess up the
> versioning system completely.

Well the idea is to copy absolutely everything, so it doesn't seem
particularly nice to ignore some directories, which would mean adding
yet another parameter to the function, meaning another source of
potential bugs.

I wonder if we should eliminate the roxygen.dir parameter altogether.

> but i think this is not an issue whether doing it in place is better or worse,
> but that there is an option which simply doesn't work like it says it would.
> if the philosophy now is more like "don't use theis feature", trying to should
> perhaps only trigger a message that the option is now deprecated. as long as
> it is actually there, i think it should just work. maybe a regular expression
> excluding common VCS directories would do the trick.

Well, I'm trying to figure out why _you_ are using it to see whether
it is worthwhile to keep the feature at all.  It's not something that
I use, and if people are only using it because that's the way roxygen
did it, then there's no real reason to keep it.

Hadley

-- 
Assistant Professor / Dobelman Family Junior Chair
Department of Statistics / Rice University
http://had.co.nz/


More information about the Roxygen-devel mailing list