[Stacomir-commits] r611 - in pkg/stacomir: . tests/testthat

noreply at r-forge.r-project.org noreply at r-forge.r-project.org
Tue Nov 16 15:10:28 CET 2021 

Author: briand
Date: 2021-11-16 15:10:28 +0100 (Tue, 16 Nov 2021)
New Revision: 611

Modified:
   pkg/stacomir/.Rbuildignore
   pkg/stacomir/.Rinstignore
   pkg/stacomir/NEWS.md
   pkg/stacomir/cran-comments.md
   pkg/stacomir/tests/testthat/
   pkg/stacomir/tests/testthat/test-14-report_ge_weight.R
Log:
preparing for 0.6.0 release

Modified: pkg/stacomir/.Rbuildignore
===================================================================
--- pkg/stacomir/.Rbuildignore	2021-11-16 13:14:56 UTC (rev 610)
+++ pkg/stacomir/.Rbuildignore	2021-11-16 14:10:28 UTC (rev 611)
@@ -26,4 +26,4 @@
 ^\.gitlab-ci.yml$
 ^LICENSE$
 ^cran-comments.md$
-^test/testhat/\~*\.*
\ No newline at end of file
+^tests/testhat/\*\.csv
\ No newline at end of file

Modified: pkg/stacomir/.Rinstignore
===================================================================
--- pkg/stacomir/.Rinstignore	2021-11-16 13:14:56 UTC (rev 610)
+++ pkg/stacomir/.Rinstignore	2021-11-16 14:10:28 UTC (rev 611)
@@ -9,4 +9,5 @@
 dev.*
 ^\.gitlab-ci.yml$
 ^LICENSE$
-^cran-comments.md$
\ No newline at end of file
+^cran-comments.md$
+^tests/testhat/\*\.csv
\ No newline at end of file

Modified: pkg/stacomir/NEWS.md
===================================================================
--- pkg/stacomir/NEWS.md	2021-11-16 13:14:56 UTC (rev 610)
+++ pkg/stacomir/NEWS.md	2021-11-16 14:10:28 UTC (rev 611)
@@ -1,9 +1,15 @@
 # stacomiR 0.6.0
 
+stacomir based on gwidget was dropped from CRAN in May 2020, it has been completely reprogrammed to remove all dependence to
+gwidget and the graphical interface will be a new shiny package (under developpement). Stacomirtools has been rewritten and submitted to CRAN 
+to connect via pool and DBI.
+
+* added import to package  `rlang` 
+* Change to adapt to new dplyr format `dplyr:n()` instead of `n()` see dplyr breaking change in version 1.0.0
 * adapted to stacomirtools new connection and connection options (using pool and DBI instead of RODC)
 * removed all dependency to gwidgetRGTK2 so in practise there is no longer a graphical interface, the shiny package is due soon.
 * added code of conduct
-* rewrote unit tests
+* rewrote unit tests increased coverage from 50 to 78 %
 
 # stacomiR 0.5.4.4 (not released on CRAN)
 

Modified: pkg/stacomir/cran-comments.md
===================================================================
--- pkg/stacomir/cran-comments.md	2021-11-16 13:14:56 UTC (rev 610)
+++ pkg/stacomir/cran-comments.md	2021-11-16 14:10:28 UTC (rev 611)
@@ -17,19 +17,22 @@
 
 ## CHECKS
 
-With no error, no warnings and 1 note : "the package was archived on CRAN due to dependency on gwidget."
+With no error, no warnings and 1 note in CRAN "the package was archived on CRAN due to dependency on gwidget."
+
 > stacomir based on gwidget was dropped from CRAN in May 2020, it has been completely reprogrammed to remove all dependence to
-gwidget
+gwidget. In Rforge windows, build fails and the error comes from stacomirtools 0.6.0 not yet available.
 
+Current version
+
 * Windows r-4.1.2 (my local machine) [0 errors v | 0 warnings v | 0 note v]
 * ubuntu (current rocker/tidyverse) https://forgemia.inra.fr/stacomi/stacomir/-/pipelines/44482  [0 errors v | 0 warnings v | 1 note x]
 * pc-linux-gnu (R 4.1.2) R-Forge [0 errors v | 0 warnings v | 1 note x]
 * pc-linux-gnu (R 4.1.2) [0 errors v | 0 warnings x | 1 note x]
 * R-Forge Windows binary (x86_64/i386) [1 errors x | 0 warnings x | 1 note x] 
-
 Error: package 'stacomirtools' 0.5.3 was found, but >= 0.6.0 is required by 'stacomiR'
-> The reason is that stacomirtools 0.6.0 is not yet on windows build in R-Forge
 
+Development version
+
 using rhub::check_for_cran()
 
 * Fedora Linux, R-devel, clang, gfortran [0 errors v | 0 warnings v | 1 note x]
@@ -36,8 +39,6 @@
 * Ubuntu Linux 20.04.1 LTS, R-release, GCC [0 errors v | 0 warnings v | 1 note x]
 * Windows Server 2008 R2 SP1, R-devel, 32/64 bit [0 errors v | 0 warnings v | 1 note x]
 
-
-
 ## NEWS 0.6.0
 
 stacomir based on gwidget was dropped from CRAN in May 2020, it has been completely reprogrammed to remove all dependence to
@@ -44,10 +45,10 @@
 gwidget and the graphical interface will be a new shiny package (under developpement). Stacomirtools has been rewritten and submitted to CRAN 
 to connect via pool and DBI.
 
-* Rewrote classes for connections using DBI and pool.
-* The connection settings can now be made using options.
-* Added unit tests to all classes.
-* now documented using Roxygen.
-* Connector classes using RODBC are now marked as deprecated and will fire note
-  deprecated.
+* added import to package  `rlang` 
+* Change to adapt to new dplyr format `dplyr:n()` instead of `n()` see dplyr breaking change in version 1.0.0
+* adapted to stacomirtools new connection and connection options (using pool and DBI instead of RODC)
+* removed all dependency to gwidgetRGTK2 so in practise there is no longer a graphical interface, the shiny package is due soon.
+* added code of conduct
+* rewrote unit tests increased coverage from 50 to 78 %
 

Index: pkg/stacomir/tests/testthat
===================================================================
--- pkg/stacomir/tests/testthat	2021-11-16 13:14:56 UTC (rev 610)
+++ pkg/stacomir/tests/testthat	2021-11-16 14:10:28 UTC (rev 611)

Property changes on: pkg/stacomir/tests/testthat
___________________________________________________________________
Modified: svn:ignore
## -84,3 +84,4 ##
 Rplots84.pdf
 Rplots9.pdf
 _snaps
+~import_coe20092015.csv
Modified: pkg/stacomir/tests/testthat/test-14-report_ge_weight.R
===================================================================
--- pkg/stacomir/tests/testthat/test-14-report_ge_weight.R	2021-11-16 13:14:56 UTC (rev 610)
+++ pkg/stacomir/tests/testthat/test-14-report_ge_weight.R	2021-11-16 14:10:28 UTC (rev 611)
@@ -75,7 +75,8 @@
 
 test_that("test that model method works", {
 			stacomi(database_expected = FALSE)	
-			data("r_gew")			
+			data("r_gew")		
+			assign("datawd","", envir = envir_stacomi)
 			# First model with nls, see Guerault and Desaunay (1993) 
 			expect_output(model(r_gew,model.type="seasonal"))
 			expect_output(model(r_gew,model.type="seasonal1"))
@@ -86,7 +87,8 @@
 test_that("test supprime method ref_coe et write method report_ge_weight", {
 			skip_on_cran()
 			stacomi(database_expected = TRUE)
-			env_set_test_stacomi()		
+			env_set_test_stacomi()	
+			assign("datawd","", envir = envir_stacomi)
 			r_gew <- new("report_ge_weight")
 			r_gew <- choice_c(r_gew,
 					dc=c(6),

More information about the Stacomir-commits mailing list