[Stacomir-commits] r538 - in pkg/stacomir: inst/cran-comments tests tests/testthat

[noreply at r-forge.r-project.org]

Author: briand
Date: 2018-10-06 07:27:06 +0200 (Sat, 06 Oct 2018)
New Revision: 538

Modified:
   pkg/stacomir/inst/cran-comments/cran-comments-v0.5.4.0.md
   pkg/stacomir/tests/testthat.R
   pkg/stacomir/tests/testthat/test-00-stacomir.R
   pkg/stacomir/tests/testthat/test-04-report_dc.R
Log:


Modified: pkg/stacomir/inst/cran-comments/cran-comments-v0.5.4.0.md
===================================================================
--- pkg/stacomir/inst/cran-comments/cran-comments-v0.5.4.0.md	2018-10-05 16:19:26 UTC (rev 537)
+++ pkg/stacomir/inst/cran-comments/cran-comments-v0.5.4.0.md	2018-10-06 05:27:06 UTC (rev 538)
@@ -1,8 +1,15 @@
 This updates the existing stacomiR package on CRAN.
 
 # Notes
+There is one warning concerning the size of the vignette pdf when built on R-Forge
+* checking sizes of PDF files under 'inst/doc' ... WARNING
+  'gs+qpdf' made some significant size reductions:
+     compacted 'stacomir.pdf' from 467Kb to 215Kb
+  consider running tools::compactPDF(gs_quality = "ebook") on these files
+But since the vignette is generated on the fly in R-forge, I don't think there is anything
+I can do about that.
 
-In addition this version adds :
+# New development
 
 * the removal of calls to the database named "test", and use of dplyr for internal calculations. 
 * the update of tests

Modified: pkg/stacomir/tests/testthat/test-00-stacomir.R
===================================================================
--- pkg/stacomir/tests/testthat/test-00-stacomir.R	2018-10-05 16:19:26 UTC (rev 537)
+++ pkg/stacomir/tests/testthat/test-00-stacomir.R	2018-10-06 05:27:06 UTC (rev 538)
@@ -160,12 +160,16 @@
 	  }					
 	})
 # test on current schema
+
 test_that("All foreign keys are present",
 	{
 	  skip_if_not(stacomi_installed(),"skipping as the program is not installed on this computer")
 	  stacomi(gr_interface=FALSE,login_window=FALSE,database_expected=TRUE)
 	  req<-new("RequeteODBC")
 	  baseODBC<-get("baseODBC", envir=envir_stacomi)
+      # ATTENTION local user may not have the rights to  connect information schema
+      # baseODBC[2] <- userlocal
+      # baseODBC[3] <- passwordlocal
 	  options(warn=-1)
 	  #warning : Coercing LHS to a list	 	
 	  options(warn=0)

Modified: pkg/stacomir/tests/testthat/test-04-report_dc.R
===================================================================
--- pkg/stacomir/tests/testthat/test-04-report_dc.R	2018-10-05 16:19:26 UTC (rev 537)
+++ pkg/stacomir/tests/testthat/test-04-report_dc.R	2018-10-06 05:27:06 UTC (rev 538)
@@ -69,7 +69,7 @@
 	  stacomi(gr_interface=FALSE,login_window=FALSE,database_expected=FALSE)
 	  data(r_dc)
 	  r_dc<-r_dc
-	  expect_output(summary(r_dc,silent=TRUE),"summary")
+	  expect_output(summary(r_dc,silent=FALSE),"summary")
       rm(list=ls(envir=envir_stacomi),envir=envir_stacomi)
 	})
 

Modified: pkg/stacomir/tests/testthat.R
===================================================================
--- pkg/stacomir/tests/testthat.R	2018-10-05 16:19:26 UTC (rev 537)
+++ pkg/stacomir/tests/testthat.R	2018-10-06 05:27:06 UTC (rev 538)
@@ -30,8 +30,8 @@
 #}
 
 test_check("stacomiR")
+devtools::test()
 
-
 #test_file(stringr::str_c(getwd(),"/tests/testthat/test-00-stacomir.R"))
 #test_file(stringr::str_c(getwd(),"/tests/testthat/test-00-zrefclasses.R"))
 #test_file(stringr::str_c(getwd(),"/tests/testthat/test-01-report_mig_mult.R"))