[Rprotobuf-commits] r907 - papers/jss

Murray Stokely mstokely at google.com
Tue Nov 25 03:52:36 CET 2014


Yay Dirk, lets finish this up and get it done.  =)

I'm addressing referee#2 feedback on section 7 now.

Then I will probably look at section 8 because the best we can do to
resolve the comment is add a few sentences of motivational text here and
there.

Addressing feedback in section 6 requires code changes for the general R
object to protobuf stuff and rexp.proto which I don't use because all my
use cases are typed.  Again I would try to get around it by writing more
motivational text, talking about future work, rather than doing all that
implementation work now.

           - Murray


On Mon, Nov 24, 2014 at 6:39 PM, <noreply at r-forge.r-project.org> wrote:

> Author: edd
> Date: 2014-11-25 03:39:23 +0100 (Tue, 25 Nov 2014)
> New Revision: 907
>
> Modified:
>    papers/jss/article.Rnw
> Log:
> three small edits
>
>
> Modified: papers/jss/article.Rnw
> ===================================================================
> --- papers/jss/article.Rnw      2014-11-25 02:26:08 UTC (rev 906)
> +++ papers/jss/article.Rnw      2014-11-25 02:39:23 UTC (rev 907)
> @@ -230,7 +230,7 @@
>
>  Protocol Buffers are a modern, language-neutral, platform-neutral,
>  extensible mechanism for sharing and storing structured data.  Some of
> -the key features provided by Protocol Buffers for data analysis include:
> +the key features provided by Protocol Buffers for data analysis are:
>
>  \begin{itemize}
>  \item \emph{Portable}:  Enable users to send and receive data between
> @@ -385,7 +385,7 @@
>  namespace.\footnote{Note that there is a significant performance
>    overhead with this RObjectTable implementation.  Because the table
>    is on the search path and isn't cacheable, lookups of symbols that
> -  are behind it in the search path can't be added to the global object
> +  are behind it in the search path cannot be added to the global object
>    cache, and R must perform an expensive lookup through all of the
>    attached environments and the protocol buffer definitions to find common
>    symbols (most notably those in base) from the global environment.
> @@ -623,8 +623,7 @@
>
>  Table~\ref{class-summary-table} lists the six primary Message and
>  Descriptor classes in \pkg{RProtoBuf}.
> -Please see the package
> -documentation for a complete description of the slots and methods for
> +The package documentation provides a complete description of the slots
> and methods for
>  each class.
>
>  % [bp]
>
> _______________________________________________
> Rprotobuf-commits mailing list
> Rprotobuf-commits at lists.r-forge.r-project.org
>
> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/rprotobuf-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.r-forge.r-project.org/pipermail/rprotobuf-commits/attachments/20141124/1c6836da/attachment-0001.html>


More information about the Rprotobuf-commits mailing list