[Rinside-commits] r201 - in pkg: . inst/examples/qt/qtdensitySVG

[noreply at r-forge.r-project.org]

Author: edd
Date: 2011-04-03 22:40:15 +0200 (Sun, 03 Apr 2011)
New Revision: 201

Modified:
   pkg/ChangeLog
   pkg/inst/examples/qt/qtdensitySVG/qtdensity.pro
Log:
updated qtdensity.pro as we no longer need -Wno-unused-parameter


Modified: pkg/ChangeLog
===================================================================
--- pkg/ChangeLog	2011-04-02 03:33:43 UTC (rev 200)
+++ pkg/ChangeLog	2011-04-03 20:40:15 UTC (rev 201)
@@ -1,6 +1,12 @@
+2011-04-03  Dirk Eddelbuettel  <edd at debian.org>
+
+	* inst/examples/qt/qtdensitySVG/qtdensity.pro: No longer need to set
+	-Wno-unused-parameter as Rcpp 0.9.3 has a fix
+
 2011-04-01  Dirk Eddelbuettel  <edd at debian.org>
 
-	* inst/examples/qt/qtdensity.cpp: Merged PNG and SVG version
+	* inst/examples/qt/qtdensitySVG/qtdensity.cpp: Merged the PNG and SVG
+	version by using a boolean based on whether cairoDevice loaded or not
 
 2011-03-25  Dirk Eddelbuettel  <edd at debian.org>
 

Modified: pkg/inst/examples/qt/qtdensitySVG/qtdensity.pro
===================================================================
--- pkg/inst/examples/qt/qtdensitySVG/qtdensity.pro	2011-04-02 03:33:43 UTC (rev 200)
+++ pkg/inst/examples/qt/qtdensitySVG/qtdensity.pro	2011-04-03 20:40:15 UTC (rev 201)
@@ -5,10 +5,12 @@
 ##
 ## Copyright (C) 2011  Dirk Eddelbuettel and Romain Francois
 
+## build an app based on the one headers and two source files
 TEMPLATE = 		app
 HEADERS =		qtdensity.h 
 SOURCES = 		qtdensity.cpp main.cpp
 
+## beyond the default configuration, also use SVG graphics
 QT += 			svg
 
 ## comment this out if you need a different version of R, 
@@ -32,7 +34,9 @@
 ## for some reason when building with Qt we get this each time
 ##   /usr/local/lib/R/site-library/Rcpp/include/Rcpp/module/Module_generated_ctor_signature.h:25: warning: unused parameter ‘classname
 ## so we turn unused parameter warnings off
-RCPPWARNING =		-Wno-unused-parameter 
+## no longer needed with Rcpp 0.9.3 or later
+#RCPPWARNING =		-Wno-unused-parameter 
+
 ## include headers and libraries for RInside embedding classes
 RINSIDEINCL = 		$$system($$R_HOME/bin/Rscript -e \'RInside:::CxxFlags\(\)\')
 RINSIDELIBS = 		$$system($$R_HOME/bin/Rscript -e \'RInside:::LdFlags\(\)\')