[Rcpp-devel] inconsistent is_na() vs. is.na()

[Thomas Tse]

Thanks. Just to note the it's traits::is_finite<STRSXP>, rather than is_na(), that needs to (always) return false


________________________________
 From: Dirk Eddelbuettel <edd at debian.org>
To: Dirk Eddelbuettel <edd at debian.org> 
Cc: Thomas Tse <tommy_228_228 at yahoo.com.hk>; "rcpp-devel at lists.r-forge.r-project.org" <rcpp-devel at lists.r-forge.r-project.org> 
Sent: Thursday, October 3, 2013 7:46 AM
Subject: Re: [Rcpp-devel] inconsistent is_na() vs. is.na()
 


Thomas,

Thanks again -- I committed both suggested changes to is_na() [ to follow R's
behaviour in case of NA and NaN, and to return false for STRSXPs ].

Keep the fixes coming in :)

Dirk

PS Diff output would be preferred, either from the diff program (usuanlly
with flag -u) or from 'svn diff'. 

-- 
Dirk Eddelbuettel | edd at debian.org | http://dirk.eddelbuettel.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.r-forge.r-project.org/pipermail/rcpp-devel/attachments/20131003/85fe90c5/attachment.html>