[Rcpp-commits] r2452 - in pkg/Rcpp: . inst/include/Rcpp

[noreply at r-forge.r-project.org]

Author: romain
Date: 2010-11-18 22:19:50 +0100 (Thu, 18 Nov 2010)
New Revision: 2452

Modified:
   pkg/Rcpp/TODO
   pkg/Rcpp/inst/include/Rcpp/Module.h
Log:
get out of the loop in time

Modified: pkg/Rcpp/TODO
===================================================================
--- pkg/Rcpp/TODO	2010-11-18 21:12:48 UTC (rev 2451)
+++ pkg/Rcpp/TODO	2010-11-18 21:19:50 UTC (rev 2452)
@@ -24,19 +24,10 @@
         gets upset when the previous version(s) coped just fine
 
 Modules 
-
-    o   Exposing constructors. For now we can only construct internal objects 
-        with the default constructor of the target class. Maybe we can provide
-        some R level dispatch. Maybe look at ?selectMethod
         
     o   Class inheritance. If we have Foo and Bar : public Foo, and we expose
         both Foo and Bar to R, R level class Bar should enjoy methods of Foo
         and the S4 inheritance should reflect the C++ level inheritance
-                
-    o   Method overloading: methods are currently stored in a map<string,.>
-        so there can only be one method for a given name, which defeats C++
-        overloading. Maybe we can do better than that. This might also need 
-        R level dispatch (?selectMethod)
         
 Syntactic sugar
 

Modified: pkg/Rcpp/inst/include/Rcpp/Module.h
===================================================================
--- pkg/Rcpp/inst/include/Rcpp/Module.h	2010-11-18 21:12:48 UTC (rev 2451)
+++ pkg/Rcpp/inst/include/Rcpp/Module.h	2010-11-18 21:19:50 UTC (rev 2452)
@@ -337,6 +337,7 @@
 		for( int i=0; i<n; i++, ++it ){
 		    if( ( (*it)->valid )( args, nargs) ){
 		        m = (*it)->method ;
+		        break ;
 		    }
 		}