[Mboost-commits] r847 - in pkg/mboostDevel: R inst

[noreply at r-forge.r-project.org]

Author: hofner
Date: 2015-04-15 17:11:58 +0200 (Wed, 15 Apr 2015)
New Revision: 847

Modified:
   pkg/mboostDevel/R/bl.R
   pkg/mboostDevel/inst/NEWS.Rd
Log:
(df2lambda) make sure that A is symmetric

Modified: pkg/mboostDevel/R/bl.R
===================================================================
--- pkg/mboostDevel/R/bl.R	2015-04-15 11:48:58 UTC (rev 846)
+++ pkg/mboostDevel/R/bl.R	2015-04-15 15:11:58 UTC (rev 847)
@@ -32,6 +32,9 @@
         dmat <- diag(ncol(XtX))
     }
     A <- XtX + dmat * options("mboost_eps")[[1]]
+    ## make sure that A is also numerically symmetric
+    if (is(A, "Matrix"))
+        A <- forceSymmetric(A)
     Rm <- solve(chol(A))
     ## singular value decomposition without singular vectors
     d <- try(svd(crossprod(Rm, dmat) %*% Rm, nu=0, nv=0)$d)

Modified: pkg/mboostDevel/inst/NEWS.Rd
===================================================================
--- pkg/mboostDevel/inst/NEWS.Rd	2015-04-15 11:48:58 UTC (rev 846)
+++ pkg/mboostDevel/inst/NEWS.Rd	2015-04-15 15:11:58 UTC (rev 847)
@@ -27,7 +27,13 @@
   }
   \subsection{Bug-fixes}{
     \itemize{
-      \item \code{PropOdds()}: fixed bug if \code{offset} was specified.
+      \item \code{PropOdds()}: fixed bug if \code{offset} was specified
+      (spotted by Madlene Nussbaum).
+      \item Bug in \code{plot.mboost()} fixed which occured if a factor
+      with equal effect estimates for different categories was plotted.
+      \item Bug in \code{df2lambda} fixed: Make sure that \code{A} is
+      symmetric if it is \code{Matrix}-object (spotted by Souhaib Ben
+      Taieb).
     }
   }
 }