[GSoC-PortA] R CMD check

[Ross Bennett]

Brian,

Thanks for the note.

Regarding the S3 generic methods. My intention with the chart.Weights.EF
function was that it would be a generic method for optimize.portfolio and
efficient.frontier objects. Since chart.Weights is already a generic method
for optimize.portfolio objects, I don't think chart.Weights can be used a
generic function to chart weights along the efficient frontier. I think I
should just rename chart.Weights.EF to chart.WeightsEF.

Regarding the other documentation issues, I'll get to work on cleaning
those up.

Thanks,
Ross


On Tue, Sep 3, 2013 at 9:02 AM, Brian G. Peterson <brian at braverock.com>wrote:

> I just ran R CMD check on current svn, and it's kind of a mess.
>
> 'R CMD build' runs fine, which is good.
>
> The vignettes take over 100 minutes to build using only one core on my 8
> (physical) core desktop.  CRAN won't like that, but I think it is
> necessary. I think we can make a case to CRAN that we need non-toy examples
> for everything, and they can get over it.
>
> The rest of check is going to need some work.
>
> By far the biggest thing is missing/incorrect parameters in the
> documentation.  This should all be worked out by making rure the roxygen
> comments are up to date and that the docs are regenerated.
>
> Another big area of check wordiness is in the S3 methods (e.g.
> chart.Scatter, chart.Weights, extractStats) , which we had agreed should be
> collapsed into a single main entry as I had done with optimize.portfolio,
> etc.  We might need to add some @method tags to the roxygen comments.
>
> I think it's rather important to start cleaning this stuff up, we've only
> got a few weeks left in GSoC.
>
> Full results of 'R CMD check --no-vignettes' and the generated manual
> attached.
>
> Regards,
>
> Brian
>
> --
> Brian G. Peterson
> http://braverock.com/brian/
> Ph: 773-459-4973
> IM: bgpbraverock
>
> _______________________________________________
> GSoC-PortA mailing list
> GSoC-PortA at lists.r-forge.r-project.org
> http://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/gsoc-porta
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.r-forge.r-project.org/pipermail/gsoc-porta/attachments/20130903/79192a53/attachment.html>