[GenABEL-dev] [Genabel-commits] r1938 - pkg/DatABEL/R

[Yury Aulchenko]

Ok, I am convinced :)

----------------
Sent from mobile device, please excuse possible typos

> On 30 Mar 2015, at 22:26, L.C. Karssen <lennart at karssen.org> wrote:
> 
> Hi Yurii,
> 
>> On 30-03-15 19:35, Yurii Aulchenko wrote:
>> Why not commenting this out (and keeping the commented code) - so we
>> remember that in principle we want this functionality.
> 
> Then I'd rather insert a short comment pointing to this commit. That's
> why we have a version control system.
> Otherwise the source files get filled more and more with commented code
> that may be useful, once was useful, never worked but might be
> interesting, etc.
> 
> Or I could add it as a Feature Request in the tracker.
> 
> 
> Lennart.
> 
>> 
>> Yurii
>> 
>>> On 30 Mar 2015, at 17:47, noreply at r-forge.r-project.org wrote:
>>> 
>>> Author: lckarssen Date: 2015-03-30 17:47:56 +0200 (Mon, 30 Mar
>>> 2015) New Revision: 1938
>>> 
>>> Modified: pkg/DatABEL/R/zzz.R Log: DatABEL: Removed all internet
>>> accesses from the .onAttach() function as requested by Prof.
>>> Ripley.
>>> 
>>> 
>>> Modified: pkg/DatABEL/R/zzz.R 
>>> ===================================================================
> --- pkg/DatABEL/R/zzz.R    2015-03-30 15:37:47 UTC (rev 1937)
>>> +++ pkg/DatABEL/R/zzz.R    2015-03-30 15:47:56 UTC (rev 1938) @@ -2,51
>>> +2,6 @@ pkgVersion <- "0.9-6" welcomeMessage <- paste0(pkg, " v.",
>>> pkgVersion," loaded\n")
>>> 
>>> -  ## check for news -  address <- c( -
>>> "http://genabel.r-forge.r-project.org/version_and_news.html", -
>>> "http://www.genabel.org/sites/default/files/version_and_news.html" 
>>> -    ) -  svtmo <- options("timeout") -  options("timeout"=2) -
>>> tryRes1 <- 0; class(tryRes1) <- "try-error" -  curaddr <- 1 -
>>> while (class(tryRes1) == "try-error" && curaddr <= length(address)
>>> ) { -    suppressWarnings( -      tryRes0 <- try(conn <-
>>> url(address[curaddr]), silent=TRUE) -      ) -
>>> suppressWarnings( -      tryRes1 <- try(fulltext <-
>>> readLines(conn), silent=TRUE) -      ) -    close(conn) -
>>> curaddr <- curaddr + 1 -  } -  if (class(tryRes1) != "try-error")
>>> { -    if (length(fulltext)>0) -      { -        ## message to all
>>> users -        strnews <- grep("<messagetoall>",
>>> tolower(fulltext)) -        endnews <- grep("</messagetoall>",
>>> tolower(fulltext)) -        if (length(strnews) > 0 &&
>>> length(endnews) > 0) -          if ((endnews-1) >= (strnews+1)) { -
>>> welcomeMessage <- paste(welcomeMessage, -
>>> fulltext[(strnews+1):(endnews-1)], -
>>> sep="\n") -          } -        ## check for specific package news 
>>> -        strnews <- grep(paste("<", pkg,"news>", sep=""),
>>> tolower(fulltext)) -        endnews <- grep(paste("</",
>>> pkg,"news>", sep=""), tolower(fulltext)) -        if
>>> (length(strnews)>0 && length(endnews)>0) -          if ((endnews-1)
>>>> = (strnews+1)) { -            welcomeMessage <-
>>> paste(welcomeMessage, -
>>> fulltext[(strnews+1):(endnews-1)], -
>>> sep="\n") -          } -      } -    ##rm(a,fulltext,ver) -  } -
>>> options("timeout"=svtmo) - .Call("checkNumBits"); 
>>> packageStartupMessage(welcomeMessage) }
>>> 
>>> _______________________________________________ Genabel-commits
>>> mailing list Genabel-commits at lists.r-forge.r-project.org 
>>> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-commits
>> 
>> _______________________________________________ Genabel-commits
>> mailing list Genabel-commits at lists.r-forge.r-project.org 
>> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-commits
> -- 
> *-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*
> L.C. Karssen
> Utrecht
> The Netherlands
> 
> lennart at karssen.org
> http://blog.karssen.org
> GPG key ID: A88F554A
> -*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-
> 
> _______________________________________________
> genabel-devel mailing list
> genabel-devel at lists.r-forge.r-project.org
> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel