[GenABEL-dev] Hardcoded paths in OmicABELnoMM's test.cpp

[Frank, Alvaro Jesus]

Which files? what do you mean hardcoded? the user already specifies the paths.
________________________________________
From: genabel-devel-bounces at lists.r-forge.r-project.org [genabel-devel-bounces at lists.r-forge.r-project.org] on behalf of L.C. Karssen [lennart at karssen.org]
Sent: Monday, October 27, 2014 9:42 PM
To: GenABEL Development list
Subject: [GenABEL-dev] Hardcoded paths in OmicABELnoMM's test.cpp

Hi Alvaro,

When I looked into the checks for OmicABELnoMM I noticed that the paths
to input and output files are hardcoded in the cpp file. While this is
(probably) OK for the file names, the fact that directories are
hardcoded also results in problems when running 'make distcheck'.

What would be the easiest way to enable the user to specify a path for
input and output files?
'make distcheck' sets an environment variable [1], so we could check for
that. But since it also sets the path as a make variable, I guess it's
easiest to add this path to the source code when compiling.
Or, maybe a bit nicer: add a command line option and wrap the check in a
shell script that provides the path.


What do you think?

Lennart.

[1]
http://www.gnu.org/software/automake/manual/html_node/Scripts_002dbased-Testsuites.html

--
*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*
L.C. Karssen
Utrecht
The Netherlands

lennart at karssen.org
http://blog.karssen.org
GPG key ID: A88F554A
-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-