[GenABEL-dev] mmscore_regression() in ProbABEL: code review

[L.C. Karssen]

Dear list (and Maarten in particular),

I've written some Doxygen documentation for the mmscore_regression()
function that Maarten recently created. While doing so I changed some of
the variable names to be a bit more understandable and documented what
the function does according to Diego's suggestion on this list some time
ago. I also slightly changed the variables that are created in the
function to get rid of one transpose() action.

My question is: could you have a look at the code (lines 57--62) in the
attached file and see if this still preservers the vectorisation
potential as mentioned in Maarten's comment in the code?

The function can be found in reg1.cpp.


Thanks a lot,

Lennart.
-- 
*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*
L.C. Karssen
Utrecht
The Netherlands

lennart at karssen.org
http://blog.karssen.org
GPG key ID: A88F554A
-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mmscore.cpp
Type: text/x-c++src
Size: 2667 bytes
Desc: not available
URL: <http://lists.r-forge.r-project.org/pipermail/genabel-devel/attachments/20140509/7e426cf5/attachment.cpp>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: OpenPGP digital signature
URL: <http://lists.r-forge.r-project.org/pipermail/genabel-devel/attachments/20140509/7e426cf5/attachment.sig>