[GenABEL-dev] Fwd: Re: [Genabel-commits] r1606 - pkg/VariABEL/src/VARlib

[L.C. Karssen]

Thanks Maksim!



Lennart.

On 11-02-14 16:06, Maksim Struchalin wrote:
> Dear Lennart,
> 
> 'unsigned' stands for 'unsigned int' but I think you are right, it is
> better to write a full type name.
> 
> best,
> Maksim
> 
> On 11/02/2014 21:28, L.C. Karssen wrote:
>> Dear Maksim, all,
>>
>> The e-mail below should have gone to the devel list, not the commit list.
>>
>>
>> Best,
>>
>> Lennart.
>>
>>
>> -------- Original Message --------
>> Subject: Re: [Genabel-commits] r1606 - pkg/VariABEL/src/VARlib
>> Date: Tue, 11 Feb 2014 11:05:12 +0100
>> From: L.C. Karssen <lennart at karssen.org>
>> Reply-To: genabel-devel at lists.r-forge.r-project.org
>> To: genabel-commits at lists.r-forge.r-project.org
>>
>> Thanks Maksim, for adding the 2df test!
>>
>> One question below:
>>
>>
>> On 11-02-14 09:29, noreply at r-forge.r-project.org wrote:
>>> Author: maksim
>>> Date: 2014-02-11 09:29:43 +0100 (Tue, 11 Feb 2014)
>>> New Revision: 1606
>>>
>>> Modified:
>>>    pkg/VariABEL/src/VARlib/var_homogeneity_tests.h
>>> Log:
>>> Fixed
>>>
>>> Modified: pkg/VariABEL/src/VARlib/var_homogeneity_tests.h
>>> ===================================================================
>>> --- pkg/VariABEL/src/VARlib/var_homogeneity_tests.h	2014-02-11 07:55:37 UTC (rev 1605)
>>> +++ pkg/VariABEL/src/VARlib/var_homogeneity_tests.h	2014-02-11 08:29:43 UTC (rev 1606)
>>> @@ -55,7 +55,7 @@
>>>  double var(my_small_vector vec);
>>>  
>>>  extern "C" {
>>> -void variance_homogeneity_test_C(double* snp, double *trait, double *design_matrix_geno_means, double *design_matrix, int *p, long unsigned* nids, double *betas, double *se, double * chi2, int * df, double * residuals, int *analys_type_, int * is_trait_na, int *testname, /*auxiliary variables:*/ double *qty, int *jpvt, double *qraux, double *work, double *v, double *x_for_ch2inv);
>>> +void variance_homogeneity_test_C(double* snp, double *trait, double *design_matrix_geno_means, double *design_matrix, int *p, long unsigned* nids, double *betas, double *se, double * chi2, int * df, double * residuals, int *analys_type_, int * is_trait_na, int *testname, /*auxiliary variables:*/ double *qty, int *jpvt, double *qraux, double *work, double *v, double *x_for_ch2inv,
>>> unsigned step);
>> I am wondering about this last argument: 'unsigned step'. Shouldn't that
>> be 'unsigned int step'?
>>
>>
>> Best,
>>
>> Lennart.
>>
>>
>>>  }
>>>  
>>>  #endif
>>>
>>> _______________________________________________
>>> Genabel-commits mailing list
>>> Genabel-commits at lists.r-forge.r-project.org
>>> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-commits
>>>
>>
>>
>> _______________________________________________
>> genabel-devel mailing list
>> genabel-devel at lists.r-forge.r-project.org
>> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel
> 
> 
> 
> _______________________________________________
> genabel-devel mailing list
> genabel-devel at lists.r-forge.r-project.org
> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel
> 

-- 
*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*
L.C. Karssen
Utrecht
The Netherlands

lennart at karssen.org
http://blog.karssen.org
GPG key ID: A88F554A
-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 230 bytes
Desc: OpenPGP digital signature
URL: <http://lists.r-forge.r-project.org/pipermail/genabel-devel/attachments/20140212/d1ad0966/attachment.sig>