[GenABEL-dev] [Genabel-commits] r1436 - pkg/GenABEL

[Yurii Aulchenko]

Thank you!

These are indeed grand level descriptors and we need to be clear and
concise o the user :)

----------------------
Yurii Aulchenko
(sent from mobile device)

> On Nov 29, 2013, at 19:03, Maksim Struchalin <m.v.struchalin at mail.ru> wrote:
>
> Hi Yurii,
>
> I changed it in a way you suggested. The message about convert.snp.illumina is deleted. It looks like I broke it when was fixing memory leak issues (deleted massives of data before the data was saved in file).
>
> best,
> Maksim
>
>
>> On 29/11/2013 20:06, Yury Aulchenko wrote:
>> Hi Maksim,
>>
>> we are including extract of these changes when announcing new releases -  in that, it is important to give some indication what the changes are about on a grand scale (performance improved? bug fixed? - which bug, did it affect all users?)
>>
>> Few questions below
>>
>>
>>> On Nov 29, 2013, at 13:50 PM, noreply at r-forge.r-project.org wrote:
>>>
>>> Author: maksim
>>> Date: 2013-11-29 13:50:14 +0100 (Fri, 29 Nov 2013)
>>> New Revision: 1436
>>>
>>> Modified:
>>>   pkg/GenABEL/ChangeLog
>>> Log:
>>> Updated info for the next submission.
>>>
>>> Modified: pkg/GenABEL/ChangeLog
>>> ===================================================================
>>> --- pkg/GenABEL/ChangeLog    2013-11-29 11:37:13 UTC (rev 1435)
>>> +++ pkg/GenABEL/ChangeLog    2013-11-29 12:50:14 UTC (rev 1436)
>>> @@ -1,3 +1,10 @@
>>> +***  v. 1.8-0
>>> +(2013.12.06)
>>> +
>>> +Fixed WARNINGs and NOTEs from R CMD check --as-cran. Fixed many errors
>> the word "errors" is dangerous (user may start thinking GenABEL was doing wrong) - I think you mean warnings here
>>
>>> reported by Jenkins: corrected coding style, fixed memory leaks, deleted unused variables.
>>> +Repaired the convert.snp.illumina() function.
>> what is this about? - was it acting wrongly? - I can foresee this comment may generate a lot of anxiety in the users who used this function - they start thinking whether there was a major bug and all their work was screwed up?
>>
>> best,
>> Y
>>
>>> +Moved data objects ge03d2.clean, ge03d2c, ge03d2ex.clean, ge03d2ex,  ge03d2 and srdta to a new R package called GenABEL.data. This made GenABEL distribution much smaller.
>>> +
>>> ***  v. 1.7-7
>>> (2013.11.04)
>>> Fixed bug #5040: Spelling of the name of G. Svischeva incorrect.
>>>
>>> _______________________________________________
>>> Genabel-commits mailing list
>>> Genabel-commits at lists.r-forge.r-project.org
>>> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-commits
>> _______________________________________________
>> Genabel-commits mailing list
>> Genabel-commits at lists.r-forge.r-project.org
>> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-commits
>
> _______________________________________________
> Genabel-commits mailing list
> Genabel-commits at lists.r-forge.r-project.org
> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-commits