[GenABEL-dev] [Genabel-commits] r705 - pkg/ProbABEL/src

[Yurii Aulchenko]

>> Defining the error() function in data.h of ProbABEL sounds like a
>> great solution to the bug, thank you!
> Thanks. But actually it is a quick and dirty solution.

Agree

> IIRC header files
> should not contain actual function definitions, only forward
> declarations. But since data.h is full of implementations anyway I
> decided to add it there as well.
>

I must admit I am the one to blame. ProbABEL was among my first
experiments with C++, so it was written in awkward way, quite dirty.

>> We still need to make distrib and put that on GenABEL-project
>> web-site. Would you have time for this?
> I will do that. Hopefully later today.
>
>>
>> Also, should we reflect the changes in CHANGES.LOG and update the
>> version to 0.1-9e, say? Not sure it is really necessary, though.
> Good point, the changelog should indeed be updated. I would indeed raise
> the version number, this bug was a show-stopper since the package
> wouldn't properly compile. So fixing it is important enough to warrant
> a separate release (and therefore an increased version number).
>

Agree, and thanks for the effort!

best wishes,
Yurii