[Genabel-commits] r1980 - www

Tue May 19 16:31:02 CEST 2015

Author: lckarssen
Date: 2015-05-19 16:31:01 +0200 (Tue, 19 May 2015)
New Revision: 1980

Modified:
   www/packageReviewGuidelines.html
   www/packageReviewGuidelines.org
Log:
Instead of only mentioning RUnit in the package ReviewGuidelines, mention unit tests in general.


Modified: www/packageReviewGuidelines.html
===================================================================

--- www/packageReviewGuidelines.html	2015-05-17 21:35:49 UTC (rev 1979)
+++ www/packageReviewGuidelines.html	2015-05-19 14:31:01 UTC (rev 1980)
@@ -4,7 +4,7 @@
 <html xmlns="http://www.w3.org/1999/xhtml" lang="en" xml:lang="en">
 <head>
 <title>GenABEL Project Package Review Guidelines</title>
-<!-- 2015-01-19 ma 11:29 -->
+<!-- 2015-05-19 di 16:29 -->
 <meta  http-equiv="Content-Type" content="text/html;charset=utf-8" />
 <meta  name="generator" content="Org-mode" />
 <meta  name="author" content="Y. Aulchenko, L.C. Karssen" />
@@ -55,6 +55,8 @@
   pre.src-sql:before   { content: 'SQL'; }
 
   table { border-collapse:collapse; }
+  caption.t-above { caption-side: top; }
+  caption.t-bottom { caption-side: bottom; }
   td, th { vertical-align:top;  }
   th.right  { text-align: center;  }
   th.left   { text-align: center;   }
@@ -159,7 +161,7 @@
 <li><a href="#sec-3-7">3.7. Does the package provide a tutorial/vignette? Can you comment on the tutorial?</a></li>
 <li><a href="#sec-3-8">3.8. Is the source code of the tutorial/vignette provided?</a></li>
 <li><a href="#sec-3-9">3.9. Does the package make use of unit/integration/etc. tests?</a></li>
-<li><a href="#sec-3-10">3.10. [For R packages] Does the package make use of RUnit testing?</a></li>
+<li><a href="#sec-3-10">3.10. [For R packages] Does the package make use of unit tests (e.g. RUnit or testthat)?</a></li>
 <li><a href="#sec-3-11">3.11. Does the code comply with the GenABEL coding standards?</a></li>
 <li><a href="#sec-3-12">3.12. Is the code readable/understandable?</a></li>
 <li><a href="#sec-3-13">3.13. Does the code contain explanatory comments?</a></li>
@@ -232,6 +234,7 @@
 </p>
 </div>
 </div>
+
 <div id="outline-container-sec-2" class="outline-2">
 <h2 id="sec-2"><span class="section-number-2">2</span> Legal issues</h2>
 <div class="outline-text-2" id="text-2">
@@ -245,7 +248,6 @@
 <h3 id="sec-2-3"><span class="section-number-3">2.3</span> Is the license GNU GPL-compatible?</h3>
 </div>
 </div>
-
 <div id="outline-container-sec-3" class="outline-2">
 <h2 id="sec-3"><span class="section-number-2">3</span> Technical quality</h2>
 <div class="outline-text-2" id="text-3">
@@ -277,7 +279,7 @@
 <h3 id="sec-3-9"><span class="section-number-3">3.9</span> Does the package make use of unit/integration/etc. tests?</h3>
 </div>
 <div id="outline-container-sec-3-10" class="outline-3">
-<h3 id="sec-3-10"><span class="section-number-3">3.10</span> [For R packages] Does the package make use of RUnit testing?</h3>
+<h3 id="sec-3-10"><span class="section-number-3">3.10</span> [For R packages] Does the package make use of unit tests (e.g. RUnit or testthat)?</h3>
 </div>
 <div id="outline-container-sec-3-11" class="outline-3">
 <h3 id="sec-3-11"><span class="section-number-3">3.11</span> Does the code comply with the <a href="codingstyle.html">GenABEL coding standards</a>?</h3>
@@ -292,7 +294,6 @@
 <h3 id="sec-3-14"><span class="section-number-3">3.14</span> Were the design and methods implemented in package discussed during the development process (e.g. on the genabel-devel mailing list)?</h3>
 </div>
 </div>
-
 <div id="outline-container-sec-4" class="outline-2">
 <h2 id="sec-4"><span class="section-number-2">4</span> Content</h2>
 <div class="outline-text-2" id="text-4">
@@ -312,7 +313,6 @@
 <h3 id="sec-4-5"><span class="section-number-3">4.5</span> Does the package use code/functions/data defined in other GenABEL packages?</h3>
 </div>
 </div>
-
 <div id="outline-container-sec-5" class="outline-2">
 <h2 id="sec-5"><span class="section-number-2">5</span> Recommendations</h2>
 <div class="outline-text-2" id="text-5">
@@ -327,7 +327,7 @@
 <div id="postamble" class="status">
 <p class="date">Date: <span class="timestamp-wrapper"><span class="timestamp"><2015-01-14 wo></span></span></p>
 <p class="author">Author: Y. Aulchenko, L.C. Karssen</p>
-<p class="date">Created: 2015-01-19 ma 11:29</p>
+<p class="date">Created: 2015-05-19 di 16:29</p>
 <p class="creator">Emacs 24.3.1 (Org mode 8.2.4)</p>
 <p class="validation"><a href="http://validator.w3.org/check?uri=referer">Validate</a></p>
 </div>

Modified: www/packageReviewGuidelines.org
===================================================================
--- www/packageReviewGuidelines.org	2015-05-17 21:35:49 UTC (rev 1979)
+++ www/packageReviewGuidelines.org	2015-05-19 14:31:01 UTC (rev 1980)
@@ -57,7 +57,7 @@
 ** Does the package provide a tutorial/vignette? Can you comment on the tutorial?
 ** Is the source code of the tutorial/vignette provided?
 ** Does the package make use of unit/integration/etc. tests?
-** [For R packages] Does the package make use of RUnit testing?
+** [For R packages] Does the package make use of unit tests (e.g. RUnit or testthat)?
 ** Does the code comply with the [[file:codingstyle.html][GenABEL coding standards]]?
 ** Is the code readable/understandable?
 ** Does the code contain explanatory comments?

