[Genabel-commits] r1705 - pkg/ProbABEL/src

[L.C. Karssen]

Hi Maarten,

That's interesting. I assume you did this in response to bug #5658?
The change you made is only for ASCII input files, right? Any idea how
this is treated in GenABEL's mach2databel() and impute2databel()? I
assume the NAs are converted to IEEE754 compatible NaN there, but I'm
not sure. If that is the case, then this would fix that bug, right?


Lennart.

On 28-04-14 11:49, noreply at r-forge.r-project.org wrote:
> Author: maartenk
> Date: 2014-04-28 11:49:36 +0200 (Mon, 28 Apr 2014)
> New Revision: 1705
> 
> Modified:
>    pkg/ProbABEL/src/gendata.cpp
> Log:
> -detecting  not avaibles in mldose file more rigid(catches [Nn][NnAa]?)
> 
> Modified: pkg/ProbABEL/src/gendata.cpp
> ===================================================================
> --- pkg/ProbABEL/src/gendata.cpp	2014-04-27 22:17:28 UTC (rev 1704)
> +++ pkg/ProbABEL/src/gendata.cpp	2014-04-28 09:49:36 UTC (rev 1705)
> @@ -57,11 +57,11 @@
>  
>          // check NaN (right now checks only first character)
>          // TODO: make catching of NaN more rigid
> -        if (*all_numbers == 'N')
> +        if (toupper(*all_numbers) == 'N')
>          {
>              result = std::numeric_limits<double>::quiet_NaN();
>              // Skip other characters of NaN
> -            while ((*all_numbers == 'a') | (*all_numbers == 'N'))
> +            while ((toupper(*all_numbers) == 'A') | (toupper(*all_numbers) == 'N'))
>              {
>                  all_numbers++;
>              }
> 
> _______________________________________________
> Genabel-commits mailing list
> Genabel-commits at lists.r-forge.r-project.org
> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-commits
> 

-- 
*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*
L.C. Karssen
Utrecht
The Netherlands

lennart at karssen.org
http://blog.karssen.org
GPG key ID: A88F554A
-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: OpenPGP digital signature
URL: <http://lists.r-forge.r-project.org/pipermail/genabel-commits/attachments/20140428/322f4695/attachment.sig>