[Stacomir-commits] r535 - in pkg/stacomir/inst: config cran-comments

[noreply at r-forge.r-project.org]

Author: briand
Date: 2018-10-05 16:57:38 +0200 (Fri, 05 Oct 2018)
New Revision: 535

Modified:
   pkg/stacomir/inst/config/test_vignette.R
   pkg/stacomir/inst/cran-comments/cran-comments-v0.5.3.1.md
Log:


Modified: pkg/stacomir/inst/config/test_vignette.R
===================================================================
--- pkg/stacomir/inst/config/test_vignette.R	2018-10-05 06:14:44 UTC (rev 534)
+++ pkg/stacomir/inst/config/test_vignette.R	2018-10-05 14:57:38 UTC (rev 535)
@@ -1,3 +1,5 @@
- setwd("F:/workspace/stacomir/pkg/stacomir")
+ setwd("c:/workspace/stacomir/pkg/stacomir")
  devtools::build_vignettes()
+ # don't work
+# tools::compactPDF("/vignette/stacomi.pdf")
  
\ No newline at end of file

Modified: pkg/stacomir/inst/cran-comments/cran-comments-v0.5.3.1.md
===================================================================
--- pkg/stacomir/inst/cran-comments/cran-comments-v0.5.3.1.md	2018-10-05 06:14:44 UTC (rev 534)
+++ pkg/stacomir/inst/cran-comments/cran-comments-v0.5.3.1.md	2018-10-05 14:57:38 UTC (rev 535)
@@ -2,26 +2,18 @@
 
 # Notes
 
-Latest message from CRAN states that the package is no longer building. The packages
- ‘gWidgetsRGtk2’ ‘RGtk2’ are no longer available on r-release-osx-x86_64 and the packages
-  ‘stacomirtools’ ‘RODBC’ are not available on  r-oldrel-osx-x86_64. There is nothing I can do about that.
-  
-There is also a fix to an error : the maintainer of Hmisc Frank E Harrell has asked me to update several of my functions namely `roundPOSIXt` and `truncPOSIXt`. This is done in this release.
+* The package is intended to work with a database, in previous development is was relying on a "test" 
+database for some calculations made with the sqldf package. All reference to a test database have been removed, and replaced with calls to dplyr for internal calculations. 
 
-In addition this version adds :
+* Updated testhat tests, those are now in a tests subdirectory as recommended by testhat developper. Most tests are relying on the database backend and a skip has been added to those tests.
 
+* developped vignette for package 
 
-* compilation of messages, fixes bug for for some year in report\_mig\_mult
-* Editing translation messages 
-* fix bug for setasqualitative method in report\_sea__age
-* updated documentation 
-* Modification in glass eel graph
-* changes to the summary-report\_mig\_interannual-method 
 
 #Testing Environments
 
 My Windows machine.
-Win Builder -- current and development.
+Win Builder -- current
 R-forge.