<div dir="ltr"><div><br></div><div><div class="gmail_extra"><div class="gmail_quote">On 9 October 2014 13:26, Dirk Eddelbuettel <span dir="ltr"><<a href="mailto:edd@debian.org" target="_blank">edd@debian.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span><br>
On 9 October 2014 at 12:12, Michele Salvadore wrote:<br>
| I submitted a pull request from my fork. Currently I have committed only a<br>
| first minor change (calendar support for bonds). I will incrementally commits<br>
| additional self-contained changes in order to monitor and discuss each step<br>
| separately. Maybe we can figure out a better way to preserve backward<br>
| compatibility.<br>
<br>
</span>That is a good approach. We could also use 'feature' branches for each new<br>
increment which is even more gradual.<br>
<br>
Now it turns out that the suggested change breaks the Travis auto-builder.<br>
That is something to avoid as we set up continuous integration to catch these<br>
things. The error happens right at the top of R CMD check:<br>
<br>
* checking whether package ‘RQuantLib’ can be installed ... ERROR<br>
Installation failed.<br>
See ‘/home/travis/build/eddelbuettel/rquantlib/RQuantLib.Rcheck/00install.out’ for details.<br>
<br>
But I don;t have access to the log...<br>
<br>
I also note that you switched to using auto -- RQuantLib is not (yet?) a<br>
C++11 project, and it may good to not force that just yet.<br></blockquote><div> </div>I thought C++11 had to be switched on already in order to support for long long type, see your comment here:<div><a href="http://lists.r-forge.r-project.org/pipermail/rquantlib-devel/2014-September/000015.html" target="_blank">http://lists.r-forge.r-project.org/pipermail/rquantlib-devel/2014-September/000015.html</a></div><div><br></div><div>Sorry about that, will revert to use explicit types.</div><div>In regards to the build I apologize, unfortunately I am stuck on a windows box for this project and I am struggling a bit with the platform. Any chance you recall how the win-builder get around the issue with the long long type discussed in the thread above without -std=c++0x?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
So the failure may simply be that you request C++11 which is not turned in<br>
src/Makevars so it fails.<br>
<span><font color="#888888"><br>
Dirk<br>
</font></span><div><div><br>
| On 8 October 2014 15:42, Dirk Eddelbuettel <<a href="mailto:edd@debian.org" target="_blank">edd@debian.org</a>> wrote:<br>
|<br>
|<br>
| On 8 October 2014 at 15:23, Michele Salvadore wrote:<br>
| | On 8 October 2014 13:52, Dirk Eddelbuettel <<a href="mailto:edd@debian.org" target="_blank">edd@debian.org</a>> wrote:<br>
| | On 8 October 2014 at 10:53, Michele Salvadore wrote:<br>
| | | I was wondering what you think of these changes. I would like to<br>
| | contribute<br>
| | | them back to the package, but I am worried about the fact the the<br>
| need to<br>
| | | extend the interface has broken backward compatibility for<br>
| FixedRateBond.<br>
| | I was<br>
| |<br>
| | I generally like backwards compatibility.<br>
| |<br>
| | Me too, as long as it is possible. <br>
|<br>
| We are on the same page. So let's see what we can do here.<br>
|<br>
| | Yes, git is my versioning tool of choice, I will clean things up a bit<br>
| and<br>
| | provide a pull request.<br>
|<br>
| Perfect.<br>
|<br>
| And then you probably know that the GH repo is currently quite a bit ahead<br>
| of<br>
| the CRAN version, so by all means use my GH sources. I think more work on<br>
| fixed income was one of my possible goals for a 0.4.0 release -- so a pull<br>
| request of yours may get us there. A lot of the other interfaces are<br>
| simpler<br>
| now thanks to Rcpp Attributes, but the signature has not changed so we<br>
| preserved backwards compatitibility there,<br>
|<br>
| Dirk<br>
|<br>
| --<br>
| <a href="http://dirk.eddelbuettel.com" target="_blank">http://dirk.eddelbuettel.com</a> | @eddelbuettel | <a href="mailto:edd@debian.org" target="_blank">edd@debian.org</a><br>
|<br>
|<br>
<br>
--<br>
<a href="http://dirk.eddelbuettel.com" target="_blank">http://dirk.eddelbuettel.com</a> | @eddelbuettel | <a href="mailto:edd@debian.org" target="_blank">edd@debian.org</a><br>
</div></div></blockquote></div><br></div></div></div>