[Rprotobuf-yada] [patch] More graceful error handling, support import patterns other than .proto$, and add simple repeated field unit test

Dirk Eddelbuettel edd at debian.org
Tue Jan 11 03:29:41 CET 2011


Hi Murray,

On 10 January 2011 at 18:04, Murray Stokely wrote:
| Hi Dirk, Romain, et al.
| 
| Turns out I'm able to use your modified RSourceTree just fine so I
| won't need to make any significant changes to the way you import the
| protocol buffer definitions, but I do have a small patch to make
| things a little easier.
| 
|    http://www.freebsdmall.com/~murray/patch_by_Murray_rprotobuf_r406.diff
| 
| While here, I added a test for the simple issue we used to have with
| RProtoBuf v0.1 but which you subsequently fixed.

Really nice simple patch -- nice idea with the pattern argument!  Patch
applies cleanly like a charm and you even adopted my somewhat random doubly
redundant (patch, rprotobuf) naming pattern in the patch/ directory ...

Do you think that's it for now?  In which case I'll probably roll up a
release with your two patches.

Thanks again, Dirk

-- 
Dirk Eddelbuettel | edd at debian.org | http://dirk.eddelbuettel.com


More information about the Rprotobuf-yada mailing list