[Rprotobuf-commits] r892 - in pkg: . tests

[noreply at r-forge.r-project.org]

Author: murray
Date: 2014-04-02 07:34:40 +0200 (Wed, 02 Apr 2014)
New Revision: 892

Modified:
   pkg/ChangeLog
   pkg/tests/runUnitTests.R
Log:
Add check to ensure there are no errors, in addition to no failures,
in the test driver to ensure R CMD CHECK fails.  Rcpp 0.11.1 now
doesn't want S4 objects to be R_NilValue which we previously depended
on.

RProtoBuf 0.4.1 has this bug and the unit test even gives a runtime
error, but this driver wasn't reporting the failure.



Modified: pkg/ChangeLog
===================================================================
--- pkg/ChangeLog	2014-03-25 17:41:37 UTC (rev 891)
+++ pkg/ChangeLog	2014-04-02 05:34:40 UTC (rev 892)
@@ -1,3 +1,8 @@
+2014-04-01  Murray Stokely  <mstokely at google.com>
+
+	* tests/runUnitTests.R: Add improved checks to ensure R CMD CHECK
+	  fails if there are any errors in the tests, not just failures.
+
 2014-03-25  Dirk Eddelbuettel  <edd at debian.org>
 
  	* DESCRIPTION (Version): Release 0.4.1

Modified: pkg/tests/runUnitTests.R
===================================================================
--- pkg/tests/runUnitTests.R	2014-03-25 17:41:37 UTC (rev 891)
+++ pkg/tests/runUnitTests.R	2014-04-02 05:34:40 UTC (rev 892)
@@ -32,5 +32,11 @@
 
 ## Return success or failure to R CMD CHECK
 if (getErrors(tests)$nFail > 0) {
-    stop("TEST FAILED!")
+   stop("TEST FAILED!")
 }
+if (getErrors(tests)$nErr > 0) {
+   stop("TEST HAD ERRORS!")
+}
+if (getErrors(tests)$nTestFunc < 1) {
+   stop("NO TEST FUNCTIONS RUN!")
+}