<div dir="ltr"><div class="gmail_default" style="font-family:trebuchet ms,sans-serif"><span class="gmail-im">
</span>Solaris no longer really matters.<span class="gmail-"> <br></span></div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif;margin-left:40px">Does that mean that CRAN will accept a package which gives errors on Solaris?</div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif;margin-left:40px"><br></div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif">You could add C++11 conditionally, ie only on Linux/macOS/Windows</div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif;margin-left:40px">Yes, but I always need C++11 for this package. I just wanted to make a small reproducible example. The bigger reproducible example is the package at <a href="https://github.com/bnosac/udpipe">https://github.com/bnosac/udpipe</a></div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif;margin-left:40px"><br></div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif">If I add the Rcpp.h header to file <a href="https://github.com/bnosac/udpipe/blob/master/src/udpipe.cpp">https://github.com/bnosac/udpipe/blob/master/src/udpipe.cpp</a>, I'm getting issues similar to this</div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif"><pre tabindex="0" class="gmail-GGHFMYIBMOB gmail-ace_text-layer gmail-ace_line gmail-GGHFMYIBPOB gmail-GGHFMYIBBU" style="font-family:"Lucida Console";font-size:9pt;font-style:inherit;font-variant:inherit;font-weight:inherit;line-height:inherit;outline:medium none;border-width:medium;border-style:none;border-color:currentcolor;word-break:break-all;margin:0px;white-space:pre-wrap;box-sizing:border-box;width:609.545px;padding:6px;color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;word-spacing:0px;background-color:rgb(255,255,255)"><span class="gmail-GGHFMYIBMOB gmail-ace_constant" style="outline:medium none;border-width:medium;border-style:none;border-color:currentcolor;word-break:break-all;margin:0px;white-space:pre-wrap;color:rgb(197,6,11)">udpipe.cpp:23406:30: error: macro "Free" passed 2 arguments, but takes just 1
alloc->Free(alloc, p->probs);</span></pre></div><br><div style="font-family:trebuchet ms,sans-serif" class="gmail_default">
Also [[Rcpp::plugins(cpp11)]] should not be needed in a package.<br></div><div style="font-family:trebuchet ms,sans-serif;margin-left:40px" class="gmail_default">Thank you for the remark. The udpipe package currently uses CXX_STD=CXX11 in Makevars and specifies SystemRequirements: C++11 in DESCRIPTION. Example was just put there to show a minimal example of the error, coming from when Rcpp compiles the attributes.</div><div style="font-family:trebuchet ms,sans-serif;margin-left:40px" class="gmail_default"><br></div><div style="font-family:trebuchet ms,sans-serif" class="gmail_default">If you could provide a pointer where I should look for a solution, this would be great otherwise the package which is now on CRAN will be rejected any time soon I think.</div><div style="font-family:trebuchet ms,sans-serif" class="gmail_default"><br></div><div style="font-family:trebuchet ms,sans-serif" class="gmail_default">best,</div><div style="font-family:trebuchet ms,sans-serif" class="gmail_default">Jan<br></div><div style="font-family:trebuchet ms,sans-serif;margin-left:40px" class="gmail_default"><br></div><div style="font-family:trebuchet ms,sans-serif;margin-left:40px" class="gmail_default"><br></div><div style="font-family:trebuchet ms,sans-serif;margin-left:40px" class="gmail_default"><br></div><br></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><br><span style="font-family:trebuchet ms,sans-serif"></span><span style="font-family:trebuchet ms,sans-serif"><font face="trebuchet ms,sans-serif">Jan Wijffels<br>Statistician<br><a href="http://www.bnosac.be" target="_blank">www.bnosac.be</a> | +32 486 611708</font><br></span></div></div></div></div></div></div></div>
<br><div class="gmail_quote">On 6 September 2017 at 18:49, Dirk Eddelbuettel <span dir="ltr"><<a href="mailto:edd@debian.org" target="_blank">edd@debian.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Hi Jan,<br>
<span class=""><br>
On 6 September 2017 at 15:03, Jan Wijffels wrote:<br>
| I'm trying to fix the installation issue I have with the package udpipe:<br>
| <a href="https://github.com/bnosac/udpipe" rel="noreferrer" target="_blank">https://github.com/bnosac/<wbr>udpipe</a> but I'm getting issues on Solaris giving<br>
| messages like this:<br>
<br>
</span>Solaris no longer really matters.<br>
<br>
| If I do not add SystemRequirements: C++11 and remove the Makevars file,<br>
<span class="">| this works fine on Solaris.<br>
<br>
</span>You could add C++11 conditionally, ie only on Linux/macOS/Windows. You could<br>
use (even a shell script named) configure for that.<br>
<span class=""><br>
| I need however C++11 as I need it in the udpipe<br>
| R package for building udpipe.cpp but can't add<br>
| to that udpipe.cpp file the following types of statements due to conflicts<br>
| on the use of the Free macro.<br>
| #include <Rcpp.h><br>
| using namespace Rcpp;<br>
| // [[Rcpp::plugins(cpp11)]]<br>
<br>
</span>Can you explain a bit more? What Free macro? Do you know about forcing R to<br>
add Rf_ to its macros?<br>
<br>
Also [[Rcpp::plugins(cpp11)]] should not be needed in a package.<br>
<span class="HOEnZb"><font color="#888888"><br>
Dirk<br>
<br>
--<br>
<a href="http://dirk.eddelbuettel.com" rel="noreferrer" target="_blank">http://dirk.eddelbuettel.com</a> | @eddelbuettel | <a href="mailto:edd@debian.org">edd@debian.org</a><br>
</font></span></blockquote></div><br></div>