On Thu, Aug 19, 2010 at 10:12 AM, Dominick Samperi <span dir="ltr"><<a href="mailto:djsamperi@gmail.com">djsamperi@gmail.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="gmail_quote"><div class="im"><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Just like any other open source project, we prefer _patches_ (and see [1] if<br>
you are unclear as to what these are -- they are not _modified copies_)<br>
rather than copies. If you want us to consider your work, the onus is on you<br>
to demonstrate a) what goal the change is meant to achieve and b) to clearly<br>
delineate what changes are to be made. Patches do the latter, whereas copies<br>
don't. Additional info on the motivation for the patch (clearer code, better<br>
performance, more foo, ...) also helps.<br></blockquote></div></div></blockquote><div> <br>To place things in context, here is my rejected contribution without the source attachments.<br>Before making these (trivial) changes I downloaded the latest SVN copies of all files, and<br>
as I said, the only difference is a few ifdef's (_MSC_VER).<br><br>So how does one determine what SVN revisions went into a particular CRAN release? Is<br>it possible to use svn to checkout the files that were used for a particular release?<br>
<br>Rejected contribution:<br><br>I'm attahcing patches for MS Visual C++ Express (only<br>tested 2008 version). Everything is ifdef-ed _MSC_VER<br>so this should have no impact on the CRAN<br>builds (including winbuilder).<br>
<br>The ifdef in XPtr.h is required because MSVC and<br>
g++ apparently disagree on the interpretation of this<br>code (fixing one causes and error in the other).<br><br>Files modified: <br> src/RcppCommon.cpp<br> src/Date.cpp<br> inst/include/RcppCommon.h<br> inst/include/Rcpp/XPtr.h<br>
<br>New files: (needed due to missing stuff under MSVC)<br> src/msvcmath.cpp<br> inst/include/msvc/math.h<br> inst/include/msvc/stdint.h (this is provided with MSVC 2010)<br> inst/include/msvc/unistd.h<br><br>Need to use MSVC compiler flags:<br>
HAVE_LOGP1<br>HAVE_EXPM1<br>HAVE_WORKING_EXPM1<br><br>The new/modifed files are attached.<br><br>It would be great if this zero-impact code could be added in<br>the next release so I don't have to maintain separate versions.<br>
<br>BTW, I don't see any branches or tags in the rcpp svn<br>repository. How does one identify the SVN version that<br>corresponds with the CRAN versions?<br><br>Thanks,<br><font color="#888888">Dominick<br></font><br>
</div></div>