[Rcpp-devel] Subsetter uses int for indexing (among other issues)?

Qiang Kou qkou at qkou.info
Thu Nov 8 08:28:03 CET 2018


Hi, William,

I think you can send the PR first. It will trigger the unit tests on github.

Best,

KK

On Wed, Nov 7, 2018 at 10:52 PM William Nolan <will at landale.net> wrote:

> Okay.  Changes are done and appear to work for *just* my test case.  Of
> course I'd like to ensure I didn't break anything along the way.
>
> I'd like to run the unit test suite on them before creating a PR, but am
> unsure on what steps to take.
>
> Given my local cloned git repo, with my edits to Subsetter.h, what's the
> right way to recompile against it and run the unit tests there?
>
> Many thanks,
> Will
>
> On Thu, Nov 8, 2018 at 2:45 PM, William Nolan <will at landale.net> wrote:
>
>> Thanks, guys.
>>
>> I submitted issue #919 <https://github.com/RcppCore/Rcpp/issues/919>
>> with a small-ish test case showing the issue.
>>
>> Will take a look at what's necessary to address.  I see subsetting is in
>> the unit tests, but this is a funny one in that verifying the fix works
>> there would require a big chunk of memory (16GB, i.e. 2^31 * 8 bytes for a
>> Numeric) to be present on the tester's machine -- seems excessive.
>>
>> Maybe it's enough for the fix to pass the existing unit tests, and pass
>> the testbed I put in the github issue.  Anyway, TBD
>>
>> On Thu, Nov 8, 2018 at 11:30 AM, Dirk Eddelbuettel <edd at debian.org>
>> wrote:
>>
>>>
>>> On 8 November 2018 at 09:19, William Nolan wrote:
>>> | Thanks. Will put together a small working example and file it. I might
>>> even attempt a fix in my copious free time ;-).
>>>
>>> Awesome :)
>>>
>>> We'll help.  Small steps and iterations work well.
>>>
>>> Dirk
>>>
>>> --
>>> http://dirk.eddelbuettel.com | @eddelbuettel | edd at debian.org
>>>
>>
>>
> _______________________________________________
> Rcpp-devel mailing list
> Rcpp-devel at lists.r-forge.r-project.org
> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/rcpp-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.r-forge.r-project.org/pipermail/rcpp-devel/attachments/20181107/e4cadfea/attachment.html>


More information about the Rcpp-devel mailing list