[Rcpp-devel] Sample function(s) for inclusion in RcppArmadillo

[Christian Gunning]

Dirk (and list for reference),

On Sun, Mar 10, 2013 at 6:16 PM, Dirk Eddelbuettel <edd at debian.org> wrote:
>
> Christian, Jonathan,
>
> On 8 March 2013 at 20:42, Christian Gunning wrote:
> | With some helpful prodding from Jonathan, I sat down with the sample
> | code today.  I moved sample.h to add-ons as per our previous
> | conversation and updated runit.sample.R accordingly.
>
> It looks great! Had some time to glance at it on a plance back from NYC but
> didn't yet write any testers.  R CMD check is very clean --- great
> submission.  MUST DO follow-up post on gallerty.rcpp.org !!

Not sure what you mean by testers here.

Johnathan indicated interest in working on the gallery post.

> I just moved the copyright dates to '2012 - 2013' as you had been at this,
> and removed one or two commented out lines.  Will commit soon.

Great, thanks.


> I don't like add-ons/ all that much as it doesn't show (Rcpp)Armadillo.
> How about any one of these:
>
>         inst/include/RcppArmadilloXtra/sample.h
>         inst/include/RcppArmadillo/extra/sample.h
>         inst/include/RcppArmadillo/add-on/sample.h
>         inst/include/RcppArmadillo/extensions/sample.h
>         inst/include/RcppArmadillo/apps/sample.h
>         inst/include/RcppArmadillo/applications/sample.h
>         [...]

I vote for "extensions".

>
> Also, should Jonathan get co-credit or not?  I'll let you guys work that out.

The writing here is all mine.  Johnathan prompted me to finish :)

> Lastly, the regression test takes 'too long' as CRAN limits us to ~ 60 sec
> per package.  I'll probably do what Romain had for Rcpp and regroup the tree
> or four cpp functions into a single source file that we can read / compile
> with a single sourceCpp() call.

Got it, thanks.

> | I also chased down the bug that was causing failure when probabilities
> | were included.  It was a small and significant misreading of the
> | original algorithm on my part that took me a while to spot.  Glad this
> | is done!
> |
> | I haven't kept up with the list (planning to do that this month), and
> | a lot of this conversation took place off-list, so I'm sending this
> | privately.  Obviously, share as you will.
>
> List is almost always better.  Even is nobody responds...
>
> Dirk
>
> | best,
> | Christian
> |
> | On Wed, Jan 30, 2013 at 7:54 AM, Dirk Eddelbuettel <edd at debian.org> wrote:
> | >
> | > On 30 January 2013 at 02:18, Christian Gunning wrote:
> | > | Thanks for the note.
> | > |
> | > | I too got swamped before I could really look at this (major office move, I've
> | > | postponed reading list).
> | > | The short story is that I thought it would (A) *just work*, and barring that
> | > | (B) I hoped it would be a quick
> | > | fix to make it *just work*.  If it doesn't *just work* (identically to R), then
> | > | (C) I need to verify that the algorithms do what they say.  I'm not entirely
> | > | comfortable (C), nor have I totally ruled out (B).  Anyway, I'll plan to poke
> | > | at this in the next 2 or 3 weeks.
> | >
> | > Let's keep at this so that it can be in the next RcppArmadillo.  We can make
> | > (at the minimum) an Rcpp Gallery post out of this, maybe even a short writeup
> | > somewhere else?
> | >
> | > Dirk
> | >
> | > --
> | > Dirk Eddelbuettel | edd at debian.org | http://dirk.eddelbuettel.com
> | >
> | >
> |
> |
> |
> | --
> | A man, a plan, a cat, a ham, a yak, a yam, a hat, a canal – Panama!
> | xuntyped binary data, working-sample [Click mouse-2 to save to a file]
>
> --
> Dirk Eddelbuettel | edd at debian.org | http://dirk.eddelbuettel.com
>
>



-- 
A man, a plan, a cat, a ham, a yak, a yam, a hat, a canal – Panama!