<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Dear All,<br>
<br>
There is some nice information about (unsigned) integer in c++ on
<a class="moz-txt-link-freetext" href="http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Integer_Types">http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Integer_Types</a>
and there problems.<br>
<br>
Kind regards,<br>
<br>
Maarten Kooyman<br>
<br>
<br>
<br>
<br>
On 12-02-14 09:43, L.C. Karssen wrote:<br>
</div>
<blockquote cite="mid:52FB343C.80209@karssen.org" type="cite">
<pre wrap="">Thanks Maksim!
Lennart.
On 11-02-14 16:06, Maksim Struchalin wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Dear Lennart,
'unsigned' stands for 'unsigned int' but I think you are right, it is
better to write a full type name.
best,
Maksim
On 11/02/2014 21:28, L.C. Karssen wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Dear Maksim, all,
The e-mail below should have gone to the devel list, not the commit list.
Best,
Lennart.
-------- Original Message --------
Subject: Re: [Genabel-commits] r1606 - pkg/VariABEL/src/VARlib
Date: Tue, 11 Feb 2014 11:05:12 +0100
From: L.C. Karssen <a class="moz-txt-link-rfc2396E" href="mailto:lennart@karssen.org"><lennart@karssen.org></a>
Reply-To: <a class="moz-txt-link-abbreviated" href="mailto:genabel-devel@lists.r-forge.r-project.org">genabel-devel@lists.r-forge.r-project.org</a>
To: <a class="moz-txt-link-abbreviated" href="mailto:genabel-commits@lists.r-forge.r-project.org">genabel-commits@lists.r-forge.r-project.org</a>
Thanks Maksim, for adding the 2df test!
One question below:
On 11-02-14 09:29, <a class="moz-txt-link-abbreviated" href="mailto:noreply@r-forge.r-project.org">noreply@r-forge.r-project.org</a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Author: maksim
Date: 2014-02-11 09:29:43 +0100 (Tue, 11 Feb 2014)
New Revision: 1606
Modified:
pkg/VariABEL/src/VARlib/var_homogeneity_tests.h
Log:
Fixed
Modified: pkg/VariABEL/src/VARlib/var_homogeneity_tests.h
===================================================================
--- pkg/VariABEL/src/VARlib/var_homogeneity_tests.h 2014-02-11 07:55:37 UTC (rev 1605)
+++ pkg/VariABEL/src/VARlib/var_homogeneity_tests.h 2014-02-11 08:29:43 UTC (rev 1606)
@@ -55,7 +55,7 @@
double var(my_small_vector vec);
extern "C" {
-void variance_homogeneity_test_C(double* snp, double *trait, double *design_matrix_geno_means, double *design_matrix, int *p, long unsigned* nids, double *betas, double *se, double * chi2, int * df, double * residuals, int *analys_type_, int * is_trait_na, int *testname, /*auxiliary variables:*/ double *qty, int *jpvt, double *qraux, double *work, double *v, double *x_for_ch2inv);
+void variance_homogeneity_test_C(double* snp, double *trait, double *design_matrix_geno_means, double *design_matrix, int *p, long unsigned* nids, double *betas, double *se, double * chi2, int * df, double * residuals, int *analys_type_, int * is_trait_na, int *testname, /*auxiliary variables:*/ double *qty, int *jpvt, double *qraux, double *work, double *v, double *x_for_ch2inv,
unsigned step);
</pre>
</blockquote>
<pre wrap="">I am wondering about this last argument: 'unsigned step'. Shouldn't that
be 'unsigned int step'?
Best,
Lennart.
</pre>
<blockquote type="cite">
<pre wrap=""> }
#endif
_______________________________________________
Genabel-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Genabel-commits@lists.r-forge.r-project.org">Genabel-commits@lists.r-forge.r-project.org</a>
<a class="moz-txt-link-freetext" href="https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-commits">https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-commits</a>
</pre>
</blockquote>
<pre wrap="">
_______________________________________________
genabel-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:genabel-devel@lists.r-forge.r-project.org">genabel-devel@lists.r-forge.r-project.org</a>
<a class="moz-txt-link-freetext" href="https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel">https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel</a>
</pre>
</blockquote>
<pre wrap="">
_______________________________________________
genabel-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:genabel-devel@lists.r-forge.r-project.org">genabel-devel@lists.r-forge.r-project.org</a>
<a class="moz-txt-link-freetext" href="https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel">https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel</a>
</pre>
</blockquote>
<pre wrap="">
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
genabel-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:genabel-devel@lists.r-forge.r-project.org">genabel-devel@lists.r-forge.r-project.org</a>
<a class="moz-txt-link-freetext" href="https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel">https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel</a></pre>
</blockquote>
<br>
</body>
</html>