<div dir="ltr"><div><div>Thank you, Lennart and Yurii=)</div><div><br></div><div>>I've got a similar feature request/bug report for ProbABEL, do you know</div><div>>what the effect of going from unsigned int to int64 will be on memory</div>
<div>>usage?</div><div><br></div><div>int64_t use 8 bytes instead of 4 bytes for int.š</div><div>In case of "reshuffle", now there are only three int64_t variables. As you can see, there is no problem with size of memory.</div>
<div>But, during "reshuffling" tile_coordinates counting many times (about one time per 5-10 doubles from data).</div><div>So, now reshuffle's runtime for data [1080traits;122756SNP;5 columns] is about 21 sec (this runtime is for --chi=25 opertaion).</div>
<div>Before correction, runtime was about 16 sec...faster than now.</div><div><br></div><div>PS: I found some another bugs in reshuffle(with --heritabilities) and ,also, ways to optimized work with big data. As soon as possible, I'll do it.</div>
</div><div class="gmail_extra" style><font face="arial, sans-serif"><br></font></div><div class="gmail_extra"><br><div class="gmail_quote">2013/7/1 Yurii Aulchenko <span dir="ltr"><<a href="mailto:yurii.aulchenko@gmail.com" target="_blank">yurii.aulchenko@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Thanks, Sodbo - does pass my test now! :)<div><br></div><div>
This is actually very good - I was so depressed not seeingšany association, then happy to discover a bug, and now even more happy to see quite a few significantšhits!<br>
<div><br></div><div>YA<br><br><div class="gmail_quote"><div><div>On Mon, Jul 1, 2013 at 9:51 AM, óÏÄÂÏ ûÁÒÁÐÏ× <span dir="ltr"><<a href="mailto:sharapovsodbo@gmail.com" target="_blank">sharapovsodbo@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><div><div dir="ltr">Dear all!<br>I fixed bug in OmicABEL_reshuffle.<br>
This bug was only for big data. The reason is, that for big output data value of tile_coordinate is higher, than max(int).<br>
For example: for data with 1080 ids and 122756 SNPs max(tile_coordinate)=1080(ids) * 122756(SNPs) * 8 (sizeof(double)) * 5 (columns:beta_1,se_1,beta_SNP,se_SNP, etc) = š5 303 059 200<br>
max(int) = 2 147 483 647<br>max(unsigned int) = 4 294 967 295<br>This values is lower than max(tile_coordinate). That's why tile_coordinates for a half of data were incorrect and senseless.<br>So, the solution of this problem is change type of variabels for tile_coordinates: I select int64_t instead of int.<br>
max (int64_t)= 9,223,372,036,854,775,808. I think this is enough!=)<br>Now, "reshuffle" works with big data correctly. Compilation for Linux and Windows was succesful.<span><font color="#888888"><div>
-- <br><div dir="ltr"><u>_________________________________</u><div>
<u><br></u>With best regards<br><br>Sodbo Zh. Sharapov<div>Phone: š+79831347688</div><div>Email: š š<a href="mailto:sharapovsodbo@gmail.com" target="_blank">sharapovsodbo@gmail.com</a></div><div>š š š š š š š<a href="mailto:sharapov@bionet.nsc.ru" target="_blank">sharapov@bionet.nsc.ru</a></div>
<div>Skype: š sharapovsodbo
</div></div></div>
</div></font></span></div>
<br></div></div>_______________________________________________<br>
genabel-devel mailing list<br>
<a href="mailto:genabel-devel@lists.r-forge.r-project.org" target="_blank">genabel-devel@lists.r-forge.r-project.org</a><br>
<a href="https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel" target="_blank">https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/genabel-devel</a><span><font color="#888888"><br>
</font></span></blockquote></div><span><font color="#888888"><br><br clear="all">
<div><br></div>-- <br>-----------------------------------------------------<br>Yurii S. Aulchenko<br><div><br></div><div>[š<a href="http://nl.linkedin.com/in/yuriiaulchenko" target="_blank">LinkedIn</a>š]š[ <a href="http://twitter.com/YuriiAulchenko" target="_blank">Twitter</a> ] [ <a href="http://yurii-aulchenko.blogspot.nl/" target="_blank">Blog</a> ]</div>
</font></span></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><u>_________________________________</u><div><u><br></u>With best regards<br><br>Sodbo Zh. Sharapov<div>Phone: š+79831347688</div><div>Email: š š<a href="mailto:sharapovsodbo@gmail.com" target="_blank">sharapovsodbo@gmail.com</a></div>
<div>š š š š š š š<a href="mailto:sharapov@bionet.nsc.ru" target="_blank">sharapov@bionet.nsc.ru</a></div><div>Skype: š sharapovsodbo
</div></div></div>
</div></div>