[GenABEL-dev] dealing with suggestions on the devel-list
yurii.aulchenko at gmail.com
Mon Mar 14 20:47:52 CET 2011
I will try to summarize the discussion of the question "how we deal
with suggested bug fixes/patches on the genabel-devel list", or at
least describe how this discussion has reflected in my mind.
1) In general, the guidelines suggested look reasonable
2) Nicola suggested that for patches we need a set of guidelines/HOWTO
on "reporting a patch". This is a separate topic to follow-up,
probably when we get a first patch, we can ask the contributor to
draft a HOWTO, and then discuss that and publish; a framework similar
to one we used to develop
3) Diego drew our attention to that fact that the framework may be
different depending on the number of suggestions we may get. This
raises a very important question, which I would like to discuss with
you as a separate topic.
Please reply if I misinterpreted your suggestions, or if you would
like to add something.
On Wed, Mar 9, 2011 at 10:17 PM, Yurii Aulchenko
<yurii.aulchenko at gmail.com> wrote:
> Dear All,
> I expect with more people looking at our code we will get more and
> more suggestions on how to fix a bug (e.g. Nicola's recent post on
> treating 'by.var' problem); we also may expect people posting patches
> (this has happened before, when genabel-devel list was not there yet).
> It is probably good time to think how we deal with these situations.
> What I could think of looks very straightforward to me, but let us
> know if you think different
> * Situation 1. We get a suggestion.
> a) discuss the suggestion on the list
> b) if suggestion passes the discussion, a committer submits outline of
> bug fix to the bug tracker
> c) a committer "assigns" bug to himself (bug tracker)
> d) the commiter implements the changes, tests, commit, ... (usual route)
> ("a committer" refers to anyone who have volunteered, though we
> understand that for the near future this will likely be one of the
> project coordinators)
> * Situation 2. We get a patch.
> a) discuss the patch on the list
> b) if patch passes the discussion, a committer "assigns" bug to
> himself (bug tracker)
> c) the committer patch the code, run checks, commit, ... (usual route)
> Let me know what you think of the proposed procedure.
> best wishes,
More information about the genabel-devel