[datatable-help] data.table() function regarding

[Steve Lianoglou]

Hi Arun,

On Thu, Aug 15, 2013 at 1:57 PM, Arunkumar Srinivasan
<aragorn168b at gmail.com> wrote:
> Steve,
> Did you have sometime to look into the edited loop (also at the test
> results)?

Sorry, I haven't. Truth be told, my eyes typically tend to gloss over
when I start spiraling down into code with lots of deparse,
substitute, quote, etc. stuff in it :-) It's going to take me a few
days before I get the time to have a sit down and look.

If the test run clean for you, though, things are likely very promising.

Sorry for the delay,

-steve


>
> Arun
>
> On Wednesday, August 14, 2013 at 10:10 PM, Arunkumar Srinivasan wrote:
>
> Dear Steve,
>
> Yes, the issue is with `deparse`. By default, it'll split the converted
> character string at every 60 characters… An easy fix is to just take the
> first element of `deparse` result (just like how `data.frame` does it):
> That is, the function should be:
>
> for (i in which(novname)) {
>    tmp <- deparse(tt[[i]])[1]
>    if (tmp == make.names(tmp))
>        vnames[i] <- tmp
> }
>
> If the `[1]` was not present then we are comparing a vector of > 1 elements
> to another… Hence the warning. With this change, I did a `R CMD CHECK <pkg>`
> and the test finished without errors. But it says at the end "there was 1
> warning". Here's the last few lines from the check:
>
> * checking tests ...
>   Running ‘autoprint.R’
>   Comparing ‘autoprint.Rout’ to ‘autoprint.Rout.save’ ... OK
>   Running ‘test-all.R’
>   Running ‘tests.R’
>  OK
> * checking for unstated dependencies in vignettes ... OK
> * checking package vignettes in ‘inst/doc’ ... OK
> * checking running R code from vignettes ...
>    ‘datatable-faq.Rnw’ ... OK
>    ‘datatable-intro.Rnw’ ... OK
>    ‘datatable-timings.Rnw’ ... OK
>  OK
> * checking re-building of vignette PDFs ... OK
> * checking PDF version of manual ... OK
>
> WARNING: There was 1 warning.
> NOTE: There was 1 note.
>
>
> Arun
>
>
>
>
> _______________________________________________
> datatable-help mailing list
> datatable-help at lists.r-forge.r-project.org
> https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/datatable-help



-- 
Steve Lianoglou
Computational Biologist
Bioinformatics and Computational Biology
Genentech